From: "David S. Miller" <davem@davemloft.net>
To: akpm@osdl.org
Cc: Steven.Hand@cl.cam.ac.uk, linux-net@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: Bug in 2.6.11.11 - udp_poll(), fragments + CONFIG_HIGHMEM
Date: Mon, 30 May 2005 15:47:33 -0700 (PDT) [thread overview]
Message-ID: <20050530.154733.85411488.davem@davemloft.net> (raw)
In-Reply-To: <20050530141714.44879df5.akpm@osdl.org>
From: Andrew Morton <akpm@osdl.org>
Date: Mon, 30 May 2005 14:17:14 -0700
> That local_bh_disable() in kmap_skb_frag() looks weird and might be
> unnecessary. Does anyone know what it's there for? Replace it with
> local_irq_save()?
The SKB kmap types are to be used only from BH context.
So the local_bh_disable() is really necessary.
This limitation causes problems elsewhere too, for example if the tg3
driver has to do the 4GB DMA boundary workaround on transmit, then it
tries to do a skb_copy() in IRQ disabled context, which thusly also
tries to do some SKB kmapping and triggers the same assertion seen
here.
Both UDP and tg3 need to be fixed to not do these operations from such
illegal contexts.
It really stinks that this error on triggers with highmem enabled.
We would have seen both bugs much earlier on otherwise.
next prev parent reply other threads:[~2005-05-30 22:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-30 14:42 Steven Hand
2005-05-30 21:17 ` Andrew Morton
2005-05-30 22:47 ` David S. Miller [this message]
2005-05-30 21:49 ` Herbert Xu
2005-05-30 22:50 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050530.154733.85411488.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Steven.Hand@cl.cam.ac.uk \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-net@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®