From: Andrew Morton <akpm@osdl.org>
To: Steven Hand <Steven.Hand@cl.cam.ac.uk>
Cc: linux-net@vger.kernel.org, linux-kernel@vger.kernel.org,
davem@davemloft.net, Steven.Hand@cl.cam.ac.uk
Subject: Re: Bug in 2.6.11.11 - udp_poll(), fragments + CONFIG_HIGHMEM
Date: Mon, 30 May 2005 14:17:14 -0700 [thread overview]
Message-ID: <20050530141714.44879df5.akpm@osdl.org> (raw)
In-Reply-To: <E1DclTK-0002qE-00@mta1.cl.cam.ac.uk>
Steven Hand <Steven.Hand@cl.cam.ac.uk> wrote:
>
> Summary: with CONFIG_HIGHMEM set, net/ipv4/udp.c::udp_poll()
> fails when rx'ing an skb with fragments.
>
> Present in [at least] 2.6.11.*, 2.6.10
>
>
> Details:
>
> User space code polling on a blocking socket fd receives an
> skb with fragments -- this is very unlikely in the common
> case but can happen with encapsulation etc; however its pretty
> much guaranteed to happen under Xen 2.x when communicating
> between dom0 and domU.
>
>
> Example backtrace from console:
>
> kernel: Badness in local_bh_enable at kernel/softirq.c:140
> kernel: [local_bh_enable+130/144] local_bh_enable+0x82/0x90
> kernel: [skb_checksum+317/704] skb_checksum+0x13d/0x2c0
> kernel: [udp_poll+154/352] udp_poll+0x9a/0x160
> kernel: [sock_poll+41/64] sock_poll+0x29/0x40
> kernel: [do_pollfd+149/160] do_pollfd+0x95/0xa0
> kernel: [do_poll+106/208] do_poll+0x6a/0xd0
> kernel: [sys_poll+353/576] sys_poll+0x161/0x240
> kernel: [sys_gettimeofday+60/144] sys_gettimeofday+0x3c/0x90
> kernel: [__pollwait+0/208] __pollwait+0x0/0xd0
> kernel: [syscall_call+7/11] syscall_call+0x7/0xb
>
Yes, that still seems to be there:
udp_poll
->spin_lock_irq()
->udp_checksum_complete
->__udp_checksum_complete
->skb_checksum
->kmap_skb_frag
->local_bh_disable
That local_bh_disable() in kmap_skb_frag() looks weird and might be
unnecessary. Does anyone know what it's there for? Replace it with
local_irq_save()?
next prev parent reply other threads:[~2005-05-30 21:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-30 14:42 Steven Hand
2005-05-30 21:17 ` Andrew Morton [this message]
2005-05-30 22:47 ` David S. Miller
2005-05-30 21:49 ` Herbert Xu
2005-05-30 22:50 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050530141714.44879df5.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=Steven.Hand@cl.cam.ac.uk \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-net@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®