From: Andrew Morton <akpm@osdl.org>
To: Rusty Lynch <rusty.lynch@intel.com>
Cc: ak@suse.de, linux-kernel@vger.kernel.org, rusty.lynch@intel.com
Subject: Re: 2.6.12-rc5-mm2 on x86_64 missing pci_bus_to_node symbol
Date: Wed, 1 Jun 2005 13:08:08 -0700 [thread overview]
Message-ID: <20050601130808.24772303.akpm@osdl.org> (raw)
In-Reply-To: <200506011857.j51IvjmE027415@linux.jf.intel.com>
Rusty Lynch <rusty.lynch@intel.com> wrote:
>
> Attempting to install a fresh 2.6.12-rc5-mm2 kernel on my x86_64 box,
> I am unable to load my e1000 driver because pci_bus_to_node is undefined.
Doh. I fixed that but forgot to include the patch in the series file, sorry.
> I'm not sure if this is the correct way of fixing this, but here is a quick
> patch to export pci_bus_to_node on x86_64.
We tend to export things at their definition site nowadays:
--- 25/arch/x86_64/kernel/mpparse.c~x86-x86_64-pcibus_to_node-fix 2005-05-31 23:19:17.000000000 -0700
+++ 25-akpm/arch/x86_64/kernel/mpparse.c 2005-05-31 23:21:29.000000000 -0700
@@ -23,6 +23,7 @@
#include <linux/kernel_stat.h>
#include <linux/mc146818rtc.h>
#include <linux/acpi.h>
+#include <linux/module.h>
#include <asm/smp.h>
#include <asm/mtrr.h>
@@ -46,6 +47,7 @@ int apic_version [MAX_APICS];
unsigned char mp_bus_id_to_type [MAX_MP_BUSSES] = { [0 ... MAX_MP_BUSSES-1] = -1 };
int mp_bus_id_to_pci_bus [MAX_MP_BUSSES] = { [0 ... MAX_MP_BUSSES-1] = -1 };
unsigned char pci_bus_to_node [256];
+EXPORT_SYMBOL(pci_bus_to_node);
static int mp_current_pci_id = 0;
/* I/O APIC entries */
_
prev parent reply other threads:[~2005-06-01 20:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-06-01 18:57 Rusty Lynch
2005-06-01 18:59 ` Andi Kleen
2005-06-01 20:08 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050601130808.24772303.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=ak@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=rusty.lynch@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®