2.6.12-rc5-mm2 on x86_64 missing pci_bus_to_node symbol

2.6.12-rc5-mm2 on x86_64 missing pci_bus_to_node symbol

[Rusty Lynch]

Attempting to install a fresh 2.6.12-rc5-mm2 kernel on my x86_64 box, 
I am unable to load my e1000 driver because pci_bus_to_node is undefined.

I'm not sure if this is the correct way of fixing this, but here is a quick 
patch to export pci_bus_to_node on x86_64.

    --rusty

 arch/x86_64/kernel/x8664_ksyms.c |    1 +
 1 files changed, 1 insertion(+)

Index: linux-2.6.12-rc5-mm2/arch/x86_64/kernel/x8664_ksyms.c
===================================================================
--- linux-2.6.12-rc5-mm2.orig/arch/x86_64/kernel/x8664_ksyms.c
+++ linux-2.6.12-rc5-mm2/arch/x86_64/kernel/x8664_ksyms.c
@@ -207,3 +207,4 @@ EXPORT_SYMBOL(flush_tlb_page);
 #endif
 
 EXPORT_SYMBOL(cpu_khz);
+EXPORT_SYMBOL(pci_bus_to_node);

Re: 2.6.12-rc5-mm2 on x86_64 missing pci_bus_to_node symbol

[Andi Kleen]

On Wed, Jun 01, 2005 at 11:57:45AM -0700, Rusty Lynch wrote:
> Attempting to install a fresh 2.6.12-rc5-mm2 kernel on my x86_64 box, 
> I am unable to load my e1000 driver because pci_bus_to_node is undefined.
> 
> I'm not sure if this is the correct way of fixing this, but here is a quick 
> patch to export pci_bus_to_node on x86_64.

Looks good, thanks.
-Andi

> 
>     --rusty
> 
>  arch/x86_64/kernel/x8664_ksyms.c |    1 +
>  1 files changed, 1 insertion(+)
> 
> Index: linux-2.6.12-rc5-mm2/arch/x86_64/kernel/x8664_ksyms.c
> ===================================================================
> --- linux-2.6.12-rc5-mm2.orig/arch/x86_64/kernel/x8664_ksyms.c
> +++ linux-2.6.12-rc5-mm2/arch/x86_64/kernel/x8664_ksyms.c
> @@ -207,3 +207,4 @@ EXPORT_SYMBOL(flush_tlb_page);
>  #endif
>  
>  EXPORT_SYMBOL(cpu_khz);
> +EXPORT_SYMBOL(pci_bus_to_node);

Re: 2.6.12-rc5-mm2 on x86_64 missing pci_bus_to_node symbol

[Andrew Morton]

Rusty Lynch <rusty.lynch@intel.com> wrote:
>
> Attempting to install a fresh 2.6.12-rc5-mm2 kernel on my x86_64 box, 
>  I am unable to load my e1000 driver because pci_bus_to_node is undefined.

Doh.  I fixed that but forgot to include the patch in the series file, sorry.

>  I'm not sure if this is the correct way of fixing this, but here is a quick 
>  patch to export pci_bus_to_node on x86_64.

We tend to export things at their definition site nowadays:

--- 25/arch/x86_64/kernel/mpparse.c~x86-x86_64-pcibus_to_node-fix	2005-05-31 23:19:17.000000000 -0700
+++ 25-akpm/arch/x86_64/kernel/mpparse.c	2005-05-31 23:21:29.000000000 -0700
@@ -23,6 +23,7 @@
 #include <linux/kernel_stat.h>
 #include <linux/mc146818rtc.h>
 #include <linux/acpi.h>
+#include <linux/module.h>
 
 #include <asm/smp.h>
 #include <asm/mtrr.h>
@@ -46,6 +47,7 @@ int apic_version [MAX_APICS];
 unsigned char mp_bus_id_to_type [MAX_MP_BUSSES] = { [0 ... MAX_MP_BUSSES-1] = -1 };
 int mp_bus_id_to_pci_bus [MAX_MP_BUSSES] = { [0 ... MAX_MP_BUSSES-1] = -1 };
 unsigned char pci_bus_to_node [256];
+EXPORT_SYMBOL(pci_bus_to_node);
 
 static int mp_current_pci_id = 0;
 /* I/O APIC entries */
_