mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Grant Grundler <grundler@parisc-linux.org>
To: Greg KH <gregkh@suse.de>
Cc: tom.l.nguyen@intel.com, linux-pci@atrey.karlin.mff.cuni.cz,
	linux-kernel@vger.kernel.org, roland@topspin.com,
	davem@davemloft.net
Subject: Re: pci_enable_msi() for everyone?
Date: Fri, 3 Jun 2005 19:31:12 -0600	[thread overview]
Message-ID: <20050604013112.GB16999@colo.lackof.org> (raw)
In-Reply-To: <20050603224551.GA10014@kroah.com>

On Fri, Jun 03, 2005 at 03:45:51PM -0700, Greg KH wrote:
> In talking with a few people about the MSI kernel code, they asked why
> we can't just do the pci_enable_msi() call for every pci device in the
> system (at somewhere like pci_enable_device() time or so).  That would
> let all drivers and devices get the MSI functionality without changing
> their code, and probably make the api a whole lot simpler.

One complication is some drivers will want to register a different
IRQ handler depending on if MSI is enabled or not.
If MSI is enabled (and usable), then some MMIO reads can be omitted.
I've posted a patch for tg3 driver:
	ftp://ftp.parisc-linux.org/patches/diff-2.6.10-tg3_MSI-03

(Just an example! It was not accepted because of buggy HW
 though it worked great on the HW I have access to.)

drivers/infiniband/hw/mthca driver is another example.

> Now I know the e1000 driver would have to specifically disable MSI for
> some of their broken versions, and possibly some other drivers might
> need this, but the downside seems quite small.
> 
> Or am I missing something pretty obvious here?

How can the driver know which IRQ handlers to register?

grant

  parent reply	other threads:[~2005-06-04  1:27 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-06-03 22:45 Greg KH
2005-06-03 23:16 ` Jeff Garzik
2005-06-04  0:01   ` Benjamin Herrenschmidt
2005-06-04  0:08     ` Jeff Garzik
2005-06-04  0:16       ` Benjamin Herrenschmidt
2005-06-04  0:34         ` Jeff Garzik
2005-06-04  6:51   ` Greg KH
2005-06-03 23:36 ` Roland Dreier
2005-06-06 22:58   ` Greg KH
2005-06-07  0:23     ` Roland Dreier
2005-06-07  5:19       ` Greg KH
2005-06-04  1:31 ` Grant Grundler [this message]
2005-06-04  6:48   ` Greg KH
2005-06-04  7:05     ` Grant Grundler
2005-06-04  7:18       ` Greg KH
2005-06-04  7:23         ` Dave Jones
2005-06-04 14:58           ` Roland Dreier
2005-06-06 23:01           ` Greg KH
2005-06-07  0:26             ` Roland Dreier
2005-06-07  5:22               ` Greg KH
2005-06-07  5:46                 ` Adam Belay
2005-06-07 17:43                   ` Luben Tuikov
2005-06-05 22:00         ` Benjamin Herrenschmidt
2005-06-06 23:00           ` Greg KH
2005-06-06 23:56             ` Benjamin Herrenschmidt
2005-06-05 19:46 ` David S. Miller
2005-06-06 22:55   ` Greg KH
2005-06-06 22:59     ` David S. Miller
2005-06-06 23:09       ` Greg KH
2005-06-06 23:08     ` Jeff Garzik
2005-06-06 23:10       ` David S. Miller
2005-06-06 23:13       ` Greg KH
2005-06-06 23:53         ` Jeff Garzik
2005-06-06 23:56           ` Greg KH
2005-06-06 23:58           ` David S. Miller
2005-06-07  4:24       ` Grant Grundler
2005-06-07  0:18     ` Roland Dreier
2005-06-07  5:21       ` Greg KH
2005-06-07 22:33 Nguyen, Tom L

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050604013112.GB16999@colo.lackof.org \
    --to=grundler@parisc-linux.org \
    --cc=davem@davemloft.net \
    --cc=gregkh@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@atrey.karlin.mff.cuni.cz \
    --cc=roland@topspin.com \
    --cc=tom.l.nguyen@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®