From: Jeff Dike <jdike@addtoit.com>
To: akpm@osdl.org, torvalds@osdl.org
Cc: linux-kernel@vger.kernel.org,
user-mode-linux-devel@lists.sourceforge.net
Subject: [PATCH 4/5] UML - Fix strace -f
Date: Mon, 06 Jun 2005 16:08:10 -0400 [thread overview]
Message-ID: <200506062008.j56K8AaI008962@ccure.user-mode-linux.org> (raw)
It turns out that we need to check for pending signals when a newly forked
process is run for the first time. With strace -f, strace needs to know
about the forked process before it gets going. If it doesn't, then it
ptraces some bogus values into its registers, and the process segfaults.
So, I added calls to interrupt_end, which does that, plus checks for
reschedules. There shouldn't be any of those, but x86 does the same thing,
so I'm copying that behavior to be safe.
Signed-off-by: Jeff Dike <jdike@addtoit.com>
Index: linux-2.6.12-rc/arch/um/kernel/skas/process_kern.c
===================================================================
--- linux-2.6.12-rc.orig/arch/um/kernel/skas/process_kern.c 2005-06-02 17:16:46.000000000 -0400
+++ linux-2.6.12-rc/arch/um/kernel/skas/process_kern.c 2005-06-02 17:16:50.000000000 -0400
@@ -68,8 +68,11 @@ void new_thread_handler(int sig)
* 0 if it just exits
*/
n = run_kernel_thread(fn, arg, ¤t->thread.exec_buf);
- if(n == 1)
+ if(n == 1){
+ /* Handle any immediate reschedules or signals */
+ interrupt_end();
userspace(¤t->thread.regs.regs);
+ }
else do_exit(0);
}
@@ -96,6 +99,8 @@ void fork_handler(int sig)
schedule_tail(current->thread.prev_sched);
current->thread.prev_sched = NULL;
+ /* Handle any immediate reschedules or signals */
+ interrupt_end();
userspace(¤t->thread.regs.regs);
}
reply other threads:[~2005-06-06 22:30 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200506062008.j56K8AaI008962@ccure.user-mode-linux.org \
--to=jdike@addtoit.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
--cc=user-mode-linux-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®