mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH 4/5] UML - Fix strace -f
@ 2005-06-06 20:08 Jeff Dike
  0 siblings, 0 replies; only message in thread
From: Jeff Dike @ 2005-06-06 20:08 UTC (permalink / raw)
  To: akpm, torvalds; +Cc: linux-kernel, user-mode-linux-devel

It turns out that we need to check for pending signals when a newly forked 
process is run for the first time.  With strace -f, strace needs to know
about the forked process before it gets going.  If it doesn't, then it
ptraces some bogus values into its registers, and the process segfaults.
So, I added calls to interrupt_end, which does that, plus checks for 
reschedules.  There shouldn't be any of those, but x86 does the same thing,
so I'm copying that behavior to be safe.

Signed-off-by: Jeff Dike <jdike@addtoit.com>

Index: linux-2.6.12-rc/arch/um/kernel/skas/process_kern.c
===================================================================
--- linux-2.6.12-rc.orig/arch/um/kernel/skas/process_kern.c	2005-06-02 17:16:46.000000000 -0400
+++ linux-2.6.12-rc/arch/um/kernel/skas/process_kern.c	2005-06-02 17:16:50.000000000 -0400
@@ -68,8 +68,11 @@ void new_thread_handler(int sig)
 	 * 0 if it just exits
 	 */
 	n = run_kernel_thread(fn, arg, &current->thread.exec_buf);
-	if(n == 1)
+	if(n == 1){
+		/* Handle any immediate reschedules or signals */
+		interrupt_end();
 		userspace(&current->thread.regs.regs);
+	}
 	else do_exit(0);
 }
 
@@ -96,6 +99,8 @@ void fork_handler(int sig)
 	schedule_tail(current->thread.prev_sched);
 	current->thread.prev_sched = NULL;
 
+	/* Handle any immediate reschedules or signals */
+	interrupt_end();
 	userspace(&current->thread.regs.regs);
 }
 


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2005-06-06 22:30 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2005-06-06 20:08 [PATCH 4/5] UML - Fix strace -f Jeff Dike

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®