mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Joe Korty <joe.korty@ccur.com>
Cc: linux-kernel@vger.kernel.org, akpm@osdl.org
Subject: Re: [PATCH] possible error in EXIT_DEAD transformation
Date: Tue, 14 Jun 2005 16:47:10 +0200	[thread overview]
Message-ID: <20050614144710.GA20228@elte.hu> (raw)
In-Reply-To: <20050614143213.GA2059@tsunami.ccur.com>


* Joe Korty <joe.korty@ccur.com> wrote:

> This assignment may have been missed, when TASK_DEAD was
> converted over to EXIT_DEAD.

> @@ -2664,7 +2664,7 @@ need_resched_nonpreemptible:
>  	spin_lock_irq(&rq->lock);
>  
>  	if (unlikely(prev->flags & PF_DEAD))
> -		prev->state = EXIT_DEAD;
> +		prev->exit_state = EXIT_DEAD;

no, here we set the dead task's state to EXIT_DEAD, so that it does not 
come back on the runqueue. Its ->exit_state is already EXIT_DEAD (or 
EXIT_ZOMBIE).

	Ingo

      reply	other threads:[~2005-06-14 14:48 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-06-14 14:32 Joe Korty
2005-06-14 14:47 ` Ingo Molnar [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050614144710.GA20228@elte.hu \
    --to=mingo@elte.hu \
    --cc=akpm@osdl.org \
    --cc=joe.korty@ccur.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®