* [PATCH] possible error in EXIT_DEAD transformation
@ 2005-06-14 14:32 Joe Korty
2005-06-14 14:47 ` Ingo Molnar
0 siblings, 1 reply; 2+ messages in thread
From: Joe Korty @ 2005-06-14 14:32 UTC (permalink / raw)
To: mingo; +Cc: linux-kernel, akpm
This assignment may have been missed, when TASK_DEAD was
converted over to EXIT_DEAD.
Signed-off-by: Joe Korty <joe.korty@ccur.com>
2.6.12-rc6-git7-jak/kernel/sched.c | 2 +-
1 files changed, 1 insertion(+), 1 deletion(-)
diff -puNa kernel/sched.c~possibly.erronous.task_state.assignment kernel/sched.c
--- 2.6.12-rc6-git7/kernel/sched.c~possibly.erronous.task_state.assignment 2005-06-14 10:25:49.000000000 -0400
+++ 2.6.12-rc6-git7-jak/kernel/sched.c 2005-06-14 10:26:05.000000000 -0400
@@ -2664,7 +2664,7 @@ need_resched_nonpreemptible:
spin_lock_irq(&rq->lock);
if (unlikely(prev->flags & PF_DEAD))
- prev->state = EXIT_DEAD;
+ prev->exit_state = EXIT_DEAD;
switch_count = &prev->nivcsw;
if (prev->state && !(preempt_count() & PREEMPT_ACTIVE)) {
_
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] possible error in EXIT_DEAD transformation
2005-06-14 14:32 [PATCH] possible error in EXIT_DEAD transformation Joe Korty
@ 2005-06-14 14:47 ` Ingo Molnar
0 siblings, 0 replies; 2+ messages in thread
From: Ingo Molnar @ 2005-06-14 14:47 UTC (permalink / raw)
To: Joe Korty; +Cc: linux-kernel, akpm
* Joe Korty <joe.korty@ccur.com> wrote:
> This assignment may have been missed, when TASK_DEAD was
> converted over to EXIT_DEAD.
> @@ -2664,7 +2664,7 @@ need_resched_nonpreemptible:
> spin_lock_irq(&rq->lock);
>
> if (unlikely(prev->flags & PF_DEAD))
> - prev->state = EXIT_DEAD;
> + prev->exit_state = EXIT_DEAD;
no, here we set the dead task's state to EXIT_DEAD, so that it does not
come back on the runqueue. Its ->exit_state is already EXIT_DEAD (or
EXIT_ZOMBIE).
Ingo
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2005-06-14 14:48 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2005-06-14 14:32 [PATCH] possible error in EXIT_DEAD transformation Joe Korty
2005-06-14 14:47 ` Ingo Molnar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®