mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@osdl.org>
To: Nick Piggin <nickpiggin@yahoo.com.au>
Cc: linux-kernel@vger.kernel.org, andrea@suse.de, mason@suse.de
Subject: Re: [patch 1/2] vm early reclaim orphaned pages (take 2)
Date: Mon, 20 Jun 2005 00:31:37 -0700	[thread overview]
Message-ID: <20050620003137.32163b67.akpm@osdl.org> (raw)
In-Reply-To: <1119252194.6240.22.camel@npiggin-nld.site>

Nick Piggin <nickpiggin@yahoo.com.au> wrote:
>
>  How about this?
>

It might be good, it's hard to tell.

Performance testing is needed.

>  --- linux-2.6.orig/mm/swap.c	2004-12-25 08:34:31.000000000 +1100
>  +++ linux-2.6/mm/swap.c	2005-06-20 17:20:28.216728238 +1000
>  @@ -87,7 +87,7 @@
>   	spin_lock_irqsave(&zone->lru_lock, flags);
>   	if (PageLRU(page) && !PageActive(page)) {
>   		list_del(&page->lru);
>  -		list_add_tail(&page->lru, &zone->inactive_list);
>  +		list_move_tail(&page->lru, &zone->inactive_list);
>   		inc_page_state(pgrotated);
>   	}
>   	if (!test_clear_page_writeback(page))
>  @@ -97,6 +97,32 @@
>   }

Correctness testing is needed too ;)

  parent reply	other threads:[~2005-06-20  7:32 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-06-17  3:23 [patch] vm early reclaim orphaned pages Nick Piggin
2005-06-17  3:34 ` Andrew Morton
2005-06-17  3:42   ` Nick Piggin
2005-06-17  4:20     ` Andrea Arcangeli
2005-06-20  7:23 ` [patch 1/2] vm early reclaim orphaned pages (take 2) Nick Piggin
2005-06-20  7:24   ` [patch 2/2] stats for orphaned pages (-mm only) Nick Piggin
2005-06-20  7:36     ` Andrew Morton
2005-06-20  7:49       ` Nick Piggin
2005-06-20  7:31   ` Andrew Morton [this message]
2005-06-20  7:32   ` [patch 1/2] vm early reclaim orphaned pages (take 2) Nick Piggin
2005-06-23  2:51     ` Rik Van Riel
2005-06-23  3:05       ` Nick Piggin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050620003137.32163b67.akpm@osdl.org \
    --to=akpm@osdl.org \
    --cc=andrea@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mason@suse.de \
    --cc=nickpiggin@yahoo.com.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®