Re: 2.6.12 breaks 8139cp

[Bjorn Helgaas <bjorn.helgaas@hp.com>]

[-- Attachment #1: Type: text/plain, Size: 930 bytes --]

On Thursday 23 June 2005 1:50 am, Pierre Ossman wrote:
> >On Wednesday 22 June 2005 3:03 pm, Pierre Ossman wrote:
> >>Upgrading from 2.6.11 to 2.6.12 caused my 8139cp network card to stop
> >>working. No error messages are emitted and everything seems to work
> >>(from the local computers point of view). But nothing can be recieved
> >>from the network.
> 
> dmesg:s included. But they don't really differ more than some cosmetic
> changes in the output strings.
> 
> The problem is I can't find anything that differs. 2.6.12 behaves more
> or less like someone cut of the rx pins in the connector. ifconfig
> doesn't report any errors so it isn't a problem with packets getting
> dropped. tcpdump only shows the outgoing packets.

Your 2.6.11 dmesg mentions the VIA IRQ fixup, but the 2.6.12 one
doesn't.  I bet something's broken there.

Can you try the attached debugging patch?  And please collect the
output of lspci, too.

[-- Attachment #2: via-irq --]
[-- Type: text/x-diff, Size: 528 bytes --]

Index: work/drivers/pci/quirks.c
===================================================================
--- work.orig/drivers/pci/quirks.c	2005-06-21 13:43:29.000000000 -0600
+++ work/drivers/pci/quirks.c	2005-06-23 10:40:55.000000000 -0600
@@ -510,7 +510,7 @@
 		pci_write_config_byte(dev, PCI_INTERRUPT_LINE, new_irq);
 	}
 }
-DECLARE_PCI_FIXUP_ENABLE(PCI_VENDOR_ID_VIA, PCI_ANY_ID, quirk_via_irq);
+DECLARE_PCI_FIXUP_ENABLE(PCI_ANY_ID, PCI_ANY_ID, quirk_via_irq);
 
 /*
  * PIIX3 USB: We have to disable USB interrupts that are