Re: 2.6.12 breaks 8139cp

[Bjorn Helgaas <bjorn.helgaas@hp.com>]

[-- Attachment #1: Type: text/plain, Size: 729 bytes --]

On Thursday 23 June 2005 11:17 am, Roberto Oppedisano wrote:
> I'm seeing the same problem with 8139cp (everithing seems fine, mii-tool
> works, but only seldom packets are received from the device). Last good
> kernel for me was 2.6.11-bk4. I tried pci=routeirq on 2.6.12, but made
> no difference. Here's lscpi output (on 2.6.11-bk4).

> 0000:02:00.0 FireWire (IEEE 1394): VIA Technologies, Inc. IEEE 1394 Host Controller (rev 80)
> 0000:02:01.0 Ethernet controller: Realtek Semiconductor Co., Ltd. RTL-8139/8139C/8139C+ (rev 20)

You have a VIA device with dev/function == 0, so 2.6.11 will do the
VIA IRQ fixup for all devices.  2.6.12 will do it only for VIA
devices.  Can you try the attached patch for debugging purposes?

[-- Attachment #2: via-irq --]
[-- Type: text/x-diff, Size: 528 bytes --]

Index: work/drivers/pci/quirks.c
===================================================================
--- work.orig/drivers/pci/quirks.c	2005-06-21 13:43:29.000000000 -0600
+++ work/drivers/pci/quirks.c	2005-06-23 10:40:55.000000000 -0600
@@ -510,7 +510,7 @@
 		pci_write_config_byte(dev, PCI_INTERRUPT_LINE, new_irq);
 	}
 }
-DECLARE_PCI_FIXUP_ENABLE(PCI_VENDOR_ID_VIA, PCI_ANY_ID, quirk_via_irq);
+DECLARE_PCI_FIXUP_ENABLE(PCI_ANY_ID, PCI_ANY_ID, quirk_via_irq);
 
 /*
  * PIIX3 USB: We have to disable USB interrupts that are