From: Christoph Hellwig <hch@infradead.org>
To: Zuzana Petrova <zpetrova@suse.cz>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fs:lock_rename()/unlock_rename() can lead to deadlock in distributed fs.
Date: Mon, 27 Jun 2005 10:39:59 +0100 [thread overview]
Message-ID: <20050627093959.GA5470@infradead.org> (raw)
In-Reply-To: <20050627092448.GA8822@lilac.suse.cz>
On Mon, Jun 27, 2005 at 11:24:49AM +0200, Zuzana Petrova wrote:
> When lock_rename(new_dir, old_dir) is called, the dentries don't match, so we
> end up in a code path that tries to acquire the inode i_sem of both the
> old_dir and new_dir, but since they point to the same inode, the second
> attempt to acquire the same i_sem results in a deadlock.
>
> A fix would be to compare the dentries ->d_inode field instead. Patch for
> kernel 2.6.12.1 attached.
No, that's bogus. Make sure the filesystem never has multiple dentries
for the same directory inode.
next prev parent reply other threads:[~2005-06-27 9:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-06-27 9:24 Zuzana Petrova
2005-06-27 9:39 ` Christoph Hellwig [this message]
2005-06-27 16:15 Nikita Danilov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050627093959.GA5470@infradead.org \
--to=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=zpetrova@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®