From: Andrew Morton <akpm@osdl.org>
To: Wen-chien Jesse Sung <jesse@cola.voip.idv.tw>
Cc: linux-kernel@vger.kernel.org, greg@kroah.com
Subject: Re: [PATCH] fix semaphore handling in __unregister_chrdev_region
Date: Tue, 28 Jun 2005 03:06:43 -0700 [thread overview]
Message-ID: <20050628030643.4f3efd01.akpm@osdl.org> (raw)
In-Reply-To: <42C11EA0.2040307@cola.voip.idv.tw>
Wen-chien Jesse Sung <jesse@cola.voip.idv.tw> wrote:
>
> Maybe this up() should be down() instead?
>
> ...
> --- linux-2.6.12-git9.orig/fs/char_dev.c 2005-06-28 16:43:27.000000000 +0800
> +++ linux-2.6.12-git9/fs/char_dev.c 2005-06-28 16:52:01.000000000 +0800
> @@ -150,7 +150,7 @@ __unregister_chrdev_region(unsigned majo
> struct char_device_struct *cd = NULL, **cp;
> int i = major_to_index(major);
>
> - up(&chrdevs_lock);
> + down(&chrdevs_lock);
Heck. Thanks.
prev parent reply other threads:[~2005-06-28 10:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-06-28 9:55 Wen-chien Jesse Sung
2005-06-28 10:06 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050628030643.4f3efd01.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=greg@kroah.com \
--cc=jesse@cola.voip.idv.tw \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®