* [PATCH] fix semaphore handling in __unregister_chrdev_region
@ 2005-06-28 9:55 Wen-chien Jesse Sung
2005-06-28 10:06 ` Andrew Morton
0 siblings, 1 reply; 2+ messages in thread
From: Wen-chien Jesse Sung @ 2005-06-28 9:55 UTC (permalink / raw)
To: linux-kernel; +Cc: greg, akpm
[-- Attachment #1: Type: text/plain, Size: 146 bytes --]
Hi,
Maybe this up() should be down() instead?
Best Regards,
Wen-chien Jesse Sung
Signed-off-by: Wen-chien Jesse Sung <jesse@cola.voip.idv.tw>
[-- Attachment #2: fix-semaphore-handling-in-__unregister_chrdev_region.diff --]
[-- Type: text/plain, Size: 456 bytes --]
--- linux-2.6.12-git9.orig/fs/char_dev.c 2005-06-28 16:43:27.000000000 +0800
+++ linux-2.6.12-git9/fs/char_dev.c 2005-06-28 16:52:01.000000000 +0800
@@ -150,7 +150,7 @@ __unregister_chrdev_region(unsigned majo
struct char_device_struct *cd = NULL, **cp;
int i = major_to_index(major);
- up(&chrdevs_lock);
+ down(&chrdevs_lock);
for (cp = &chrdevs[i]; *cp; cp = &(*cp)->next)
if ((*cp)->major == major &&
(*cp)->baseminor == baseminor &&
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] fix semaphore handling in __unregister_chrdev_region
2005-06-28 9:55 [PATCH] fix semaphore handling in __unregister_chrdev_region Wen-chien Jesse Sung
@ 2005-06-28 10:06 ` Andrew Morton
0 siblings, 0 replies; 2+ messages in thread
From: Andrew Morton @ 2005-06-28 10:06 UTC (permalink / raw)
To: Wen-chien Jesse Sung; +Cc: linux-kernel, greg
Wen-chien Jesse Sung <jesse@cola.voip.idv.tw> wrote:
>
> Maybe this up() should be down() instead?
>
> ...
> --- linux-2.6.12-git9.orig/fs/char_dev.c 2005-06-28 16:43:27.000000000 +0800
> +++ linux-2.6.12-git9/fs/char_dev.c 2005-06-28 16:52:01.000000000 +0800
> @@ -150,7 +150,7 @@ __unregister_chrdev_region(unsigned majo
> struct char_device_struct *cd = NULL, **cp;
> int i = major_to_index(major);
>
> - up(&chrdevs_lock);
> + down(&chrdevs_lock);
Heck. Thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2005-06-28 10:07 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2005-06-28 9:55 [PATCH] fix semaphore handling in __unregister_chrdev_region Wen-chien Jesse Sung
2005-06-28 10:06 ` Andrew Morton
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®