[PATCH] Multipath routing algorithm determination

[PATCH] Multipath routing algorithm determination

[Patrick Jenkins]

Hi,

This patch assigns the multipath routing algorithm into the fib_info
struct's fib_mp_alg variable. Previously, the algorithm was always set to
IP_MP_ALG_NONE which was incorrect. This patch corrects the problem by
assigning the correct value when a fib_info is initialized.

This patch was tested against kernel 2.6.12.1 for all multipath routing
algorithms (none, round robin, interface round robin, random, weighted
random).

Please look this patch over and apply it to the kernel. I have been unable 
to contact the creators of the multipath algorithm feature so this is why 
I sent it to the lkml.

I am not a member of the list so please cc me in the reply.

Signed-off-by: Patrick Jenkins <patjenk@wam.umd.edu>

--- net/ipv4/fib_semantics.orig.c       2005-06-30 18:47:05.000000000 
-0400
+++ net/ipv4/fib_semantics.c    2005-06-30 18:55:08.000000000 -0400
@@ -9,6 +9,9 @@
   *
   * Authors:    Alexey Kuznetsov, <kuznet@ms2.inr.ac.ru>
   *
+ * Fixes:
+ *             Patrick Jenkins :       multipath routing algorithm wasnt 
being assigned correctly
+ *
   *             This program is free software; you can redistribute it 
and/or
   *             modify it under the terms of the GNU General Public 
License
   *             as published by the Free Software Foundation; either 
version
@@ -650,9 +653,20 @@ fib_create_info(const struct rtmsg *r, s
  #else
         const int nhs = 1;
  #endif
+
  #ifdef CONFIG_IP_ROUTE_MULTIPATH_CACHED
+#ifdef CONFIG_IP_ROUTE_MULTIPATH_RR
+       u32 mp_alg = IP_MP_ALG_RR;
+#elif CONFIG_IP_ROUTE_MULTIPATH_DRR
+       u32 mp_alg = IP_MP_ALG_DRR;
+#elif CONFIG_IP_ROUTE_MULTIPATH_RANDOM
+       u32 mp_alg = IP_MP_ALG_RANDOM;
+#elif CONFIG_IP_ROUTE_MULTIPATH_WRANDOM
+       u32 mp_alg = IP_MP_ALG_WRANDOM;
+#else
         u32 mp_alg = IP_MP_ALG_NONE;
-#endif
+#endif /* multipath algorithm determination */
+#endif /* CONFIG_IP_ROUTE_MULTIPATH_CACHED */

         /* Fast check to catch the most weird cases */
         if (fib_props[r->rtm_type].scope > r->rtm_scope)

Re: [PATCH] Multipath routing algorithm determination

[David S. Miller]

Please post this to the Linux Networking development list,
netdev@vger.kernel.org, as many networking developers do not
read linux-kernel.

Thanks.