[PATCH] Fix the recent C-state with FADT regression

[PATCH] Fix the recent C-state with FADT regression

[Venkatesh Pallipadi]

Attached patch fixes the recent C-state based on FADT regression reported by
Kevin.

Please apply.

Thanks,
Venki


Fix the regression with c1_default_handler on some systems where C-states come
from FADT.

Thanks to Kevin Radloff for identifying the issue and also root causing on 
exact line of code that is causing the issue.

Signed-off-by: Venkatesh Pallipadi <venkatesh.pallipadi@intel.com>

diff -purN  linux-2.6.13-rc1-mm1//drivers/acpi/processor_idle.c.org linux-2.6.13-rc1-mm1//drivers/acpi/processor_idle.c
--- linux-2.6.13-rc1-mm1//drivers/acpi/processor_idle.c.org	2005-07-14 23:19:45.038854688 -0700
+++ linux-2.6.13-rc1-mm1//drivers/acpi/processor_idle.c	2005-07-14 23:21:47.292269344 -0700
@@ -881,7 +881,7 @@ static int acpi_processor_get_power_info
 	result = acpi_processor_get_power_info_cst(pr);
 	if ((result) || (acpi_processor_power_verify(pr) < 2)) {
 		result = acpi_processor_get_power_info_fadt(pr);
-		if (result)
+		if ((result) || (acpi_processor_power_verify(pr) < 2))
 			result = acpi_processor_get_power_info_default_c1(pr);
 	}
 

Re: [PATCH] Fix the recent C-state with FADT regression

[Andrew Morton]

Venkatesh Pallipadi <venkatesh.pallipadi@intel.com> wrote:
>
> 
> 
> Attached patch fixes the recent C-state based on FADT regression reported by
> Kevin.
> 
> Please apply.
> 
> Thanks,
> Venki
> 
> 
> Fix the regression with c1_default_handler on some systems where C-states come
> from FADT.
> 
> Thanks to Kevin Radloff for identifying the issue and also root causing on 
> exact line of code that is causing the issue.
> 
> Signed-off-by: Venkatesh Pallipadi <venkatesh.pallipadi@intel.com>
> 
> diff -purN  linux-2.6.13-rc1-mm1//drivers/acpi/processor_idle.c.org linux-2.6.13-rc1-mm1//drivers/acpi/processor_idle.c
> --- linux-2.6.13-rc1-mm1//drivers/acpi/processor_idle.c.org	2005-07-14 23:19:45.038854688 -0700
> +++ linux-2.6.13-rc1-mm1//drivers/acpi/processor_idle.c	2005-07-14 23:21:47.292269344 -0700
> @@ -881,7 +881,7 @@ static int acpi_processor_get_power_info
>  	result = acpi_processor_get_power_info_cst(pr);
>  	if ((result) || (acpi_processor_power_verify(pr) < 2)) {
>  		result = acpi_processor_get_power_info_fadt(pr);
> -		if (result)
> +		if ((result) || (acpi_processor_power_verify(pr) < 2))
>  			result = acpi_processor_get_power_info_default_c1(pr);
>  	}
>

It turns out I've had this in my tree since July 6 (from Jindrich
Makovicka), sent to Len on July 9.  Maybe he's merged it somewhere already.

I have seven acpi patches here, some of which have been in -mm for a very
long time.  I'll resend them all.  Could someone please promptly ack them for
2.6.13 or merge them somewhere or nack the things?

Thanks.