From: domen@coderock.org
To: spyro@f2s.com
Cc: linux-kernel@vger.kernel.org,
Christophe Lucas <clucas@rotomalug.org>,
domen@coderock.org
Subject: [patch 1/1] Audit return code of create_proc_*
Date: Fri, 15 Jul 2005 00:19:23 +0200 [thread overview]
Message-ID: <20050714221923.543951000@homer> (raw)
[-- Attachment #1: return_code-arch_arm26_kernel_ecard --]
[-- Type: text/plain, Size: 1077 bytes --]
From: Christophe Lucas <clucas@rotomalug.org>
Audit return of create_proc_* functions.
Signed-off-by: Christophe Lucas <clucas@rotomalug.org>
Signed-off-by: Domen Puncer <domen@coderock.org>
---
ecard.c | 11 +++++++++--
1 files changed, 9 insertions(+), 2 deletions(-)
Index: quilt/arch/arm26/kernel/ecard.c
===================================================================
--- quilt.orig/arch/arm26/kernel/ecard.c
+++ quilt/arch/arm26/kernel/ecard.c
@@ -522,9 +522,16 @@ static struct proc_dir_entry *proc_bus_e
static void ecard_proc_init(void)
{
+ struct proc_dir_entry *proc_entry;
proc_bus_ecard_dir = proc_mkdir("ecard", proc_bus);
- create_proc_info_entry("devices", 0, proc_bus_ecard_dir,
- get_ecard_dev_info);
+ if (!proc_bus_ecard_dir)
+ printk(KERN_WARNING "Unable to create proc dir entry.\n");
+ else {
+ proc_entry = create_proc_info_entry("devices", 0,
+ proc_bus_ecard_dir, get_ecard_dev_info);
+ if (!proc_entry)
+ printk(KERN_WARNING "ecard: Unable to create proc entry\n");
+ }
}
#define ec_set_resource(ec,nr,st,sz,flg) \
--
next reply other threads:[~2005-07-14 22:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-07-14 22:19 domen [this message]
2005-07-16 11:56 ` Ingo Oeser
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050714221923.543951000@homer \
--to=domen@coderock.org \
--cc=clucas@rotomalug.org \
--cc=linux-kernel@vger.kernel.org \
--cc=spyro@f2s.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®