From: Ingo Oeser <ioe-lkml@rameria.de>
To: domen@coderock.org
Cc: linux-kernel@vger.kernel.org
Subject: Re: [patch 1/1] Audit return code of create_proc_*
Date: Sat, 16 Jul 2005 13:56:29 +0200 [thread overview]
Message-ID: <200507161356.36058.ioe-lkml@rameria.de> (raw)
In-Reply-To: <20050714221923.543951000@homer>
[-- Attachment #1: Type: text/plain, Size: 858 bytes --]
Hi Domen,
On Friday 15 July 2005 00:19, you wrote:
> Audit return of create_proc_* functions.
This (and related changes) spam the log, if
kernel is compiled without /proc-support.
Kernels without /proc-support are quite common in the embedded world.
Just provide a function in a suitable header
(include/linux/proc_fs.h looks promising)
file, which contains the following:
#ifdef CONFIG_PROC_FS
#define procfs_failure(msg) do { printk(msg); } while(0)
#else
#define procfs_failure(msg) do {} while(0)
#endif
and use it instead of the direct printk call.
That way you get both: Your GCC or checking tool warning is silenced
and the log is not spammed for the embedded people.
For code, which is broken without procfs, the code
should be fixed or it should select PROC_FS in its Kconfig file.
Regards
Ingo Oeser
[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]
prev parent reply other threads:[~2005-07-16 11:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-07-14 22:19 domen
2005-07-16 11:56 ` Ingo Oeser [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200507161356.36058.ioe-lkml@rameria.de \
--to=ioe-lkml@rameria.de \
--cc=domen@coderock.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®