From: Johannes Stezenbach <js@linuxtv.org>
To: Andrew Benton <b3nt@ukonline.co.uk>
Cc: linux-kernel@vger.kernel.org, Andrew Morton <akpm@osdl.org>,
Patrick Boettcher <pb@linuxtv.org>,
Michael Krufky <mkrufky@m1k.net>
Subject: Re: cx22702.c, 2.6.13-rc3 and a pci Hauppauge Nova-T DVB-T TV card
Date: Fri, 15 Jul 2005 13:09:38 +0200 [thread overview]
Message-ID: <20050715110938.GB9976@linuxtv.org> (raw)
In-Reply-To: <42D77E37.5010908@ukonline.co.uk>
Andrew Benton wrote:
> My pci TV card (a Hauppauge Nova-T DVB-T) works fine with a 2.6.13-rc2
> kernel but won't work with a 2.6.13-rc3 by a process of elimination I've
> found that if I reverse this part of the 2.6.13-rc3 patch the card works
> fine. Please do not include this in the 2.6.13 kernel.
Reversing this patch is not the right fix as it would break
support for the cxusb.c driver. I guess the output_mode needs to
be set for the Hauppauge Nova-T DVB-T (cx88-dvb.c).
cx88-dvb.c is in video4linux CVS, not DVB CVS.
Patrick, can you send a patch for this?
Johannes
> diff --git a/drivers/media/dvb/frontends/cx22702.c
> b/drivers/media/dvb/frontends/cx22702.c
> --- a/drivers/media/dvb/frontends/cx22702.c
> +++ b/drivers/media/dvb/frontends/cx22702.c
> @@ -76,7 +76,6 @@ static u8 init_tab [] = {
> 0x49, 0x56,
> 0x6b, 0x1e,
> 0xc8, 0x02,
> - 0xf8, 0x02,
> 0xf9, 0x00,
> 0xfa, 0x00,
> 0xfb, 0x00,
> @@ -347,10 +346,11 @@ static int cx22702_init (struct dvb_fron
> for (i=0; i<sizeof(init_tab); i+=2)
> cx22702_writereg (state, init_tab[i], init_tab[i+1]);
>
> + cx22702_writereg (state, 0xf8, (state->config->output_mode << 1) & 0x02);
>
> /* init PLL */
> if (state->config->pll_init) {
> - cx22702_writereg (state, 0x0D, cx22702_readreg(state,0x0D) &0xfe);
> + cx22702_writereg (state, 0x0D, cx22702_readreg(state,0x0D) & 0xfe);
> state->config->pll_init(fe);
> cx22702_writereg (state, 0x0D, cx22702_readreg(state,0x0D) | 1);
> }
next prev parent reply other threads:[~2005-07-15 11:10 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-07-15 9:13 Andrew Benton
2005-07-15 11:09 ` Johannes Stezenbach [this message]
2005-07-15 11:11 ` Patrick Boettcher
2005-07-15 11:36 ` Mauro Carvalho Chehab
2005-07-15 12:57 ` Andrew Benton
2005-07-15 13:01 ` Patrick Boettcher
2005-07-15 13:29 ` Mauro Carvalho Chehab
2005-07-15 13:34 ` Patrick Boettcher
2005-07-15 14:47 ` Andrew Benton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050715110938.GB9976@linuxtv.org \
--to=js@linuxtv.org \
--cc=akpm@osdl.org \
--cc=b3nt@ukonline.co.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=mkrufky@m1k.net \
--cc=pb@linuxtv.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®