From: Patrick Boettcher <patrick.boettcher@desy.de>
To: Johannes Stezenbach <js@linuxtv.org>
Cc: Andrew Benton <b3nt@ukonline.co.uk>,
linux-kernel@vger.kernel.org, Andrew Morton <akpm@osdl.org>,
Michael Krufky <mkrufky@m1k.net>,
video4linux-list@redhat.com
Subject: Re: cx22702.c, 2.6.13-rc3 and a pci Hauppauge Nova-T DVB-T TV card
Date: Fri, 15 Jul 2005 13:11:50 +0200 (CEST) [thread overview]
Message-ID: <Pine.LNX.4.61.0507151308450.15841@pub2.ifh.de> (raw)
In-Reply-To: <20050715110938.GB9976@linuxtv.org>
On Fri, 15 Jul 2005, Johannes Stezenbach wrote:
> Andrew Benton wrote:
>> My pci TV card (a Hauppauge Nova-T DVB-T) works fine with a 2.6.13-rc2
>> kernel but won't work with a 2.6.13-rc3 by a process of elimination I've
>> found that if I reverse this part of the 2.6.13-rc3 patch the card works
>> fine. Please do not include this in the 2.6.13 kernel.
>
> Reversing this patch is not the right fix as it would break
> support for the cxusb.c driver. I guess the output_mode needs to
> be set for the Hauppauge Nova-T DVB-T (cx88-dvb.c).
> cx88-dvb.c is in video4linux CVS, not DVB CVS.
>
> Patrick, can you send a patch for this?
Hmm, yes. When I changed the cx22702-driver to make it work with the
cxusb-driver, I added another field to the struct cx22702_config to
determine the output type.
I was well aware that this breaks support for the PCI cards, that's why I
created a patch for the cx88-dvb.c and posted it the v4l-mailing list and
ask for inclusion.
This was the Mail:
http://www.linuxtv.org/pipermail/linux-dvb/2005-June/002383.html
This is the patch:
Index: cx88-dvb.c
===================================================================
RCS file: /cvs/video4linux/video4linux/cx88-dvb.c,v
retrieving revision 1.42
diff -u -3 -p -r1.42 cx88-dvb.c
--- cx88-dvb.c 12 Jul 2005 15:44:55 -0000 1.42
+++ cx88-dvb.c 15 Jul 2005 11:06:22 -0000
@@ -166,12 +166,14 @@ static int mt352_pll_set(struct dvb_fron
static struct mt352_config dvico_fusionhdtv = {
.demod_address = 0x0F,
+ .output_mode = CX22702_SERIAL_OUTPUT,
.demod_init = dvico_fusionhdtv_demod_init,
.pll_set = mt352_pll_set,
};
static struct mt352_config dntv_live_dvbt_config = {
.demod_address = 0x0f,
+ .output_mode = CX22702_SERIAL_OUTPUT,
.demod_init = dntv_live_dvbt_demod_init,
.pll_set = mt352_pll_set,
};
Please include. Thanks
Signed-off-by: Patrick Boettcher <pb@linuxtv.org>
best regards,
Patrick.
--
Mail: patrick.boettcher@desy.de
WWW: http://www.wi-bw.tfh-wildau.de/~pboettch/
next prev parent reply other threads:[~2005-07-15 11:17 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-07-15 9:13 Andrew Benton
2005-07-15 11:09 ` Johannes Stezenbach
2005-07-15 11:11 ` Patrick Boettcher [this message]
2005-07-15 11:36 ` Mauro Carvalho Chehab
2005-07-15 12:57 ` Andrew Benton
2005-07-15 13:01 ` Patrick Boettcher
2005-07-15 13:29 ` Mauro Carvalho Chehab
2005-07-15 13:34 ` Patrick Boettcher
2005-07-15 14:47 ` Andrew Benton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.61.0507151308450.15841@pub2.ifh.de \
--to=patrick.boettcher@desy.de \
--cc=akpm@osdl.org \
--cc=b3nt@ukonline.co.uk \
--cc=js@linuxtv.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mkrufky@m1k.net \
--cc=video4linux-list@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®