* Inotify patch missed arch/x86_64/ia32/sys_ia32.c
@ 2005-07-15 11:27 Stephen C. Tweedie
2005-07-15 12:15 ` Andi Kleen
0 siblings, 1 reply; 2+ messages in thread
From: Stephen C. Tweedie @ 2005-07-15 11:27 UTC (permalink / raw)
To: linux-kernel; +Cc: Andi Kleen, David Woodhouse, Stephen Tweedie
Hi,
The inotify patch just added a line
+ fsnotify_open(f->f_dentry);
to sys_open, but it missed the x86_64 compatibility sys32_open()
equivalent in arch/x86_64/ia32/sys_ia32.c.
Andi, perhaps it's time to factor out the guts of sys_open from the flag
munging to keep as much of that code as common as possible, and avoid
this sort of maintenance problem in the future?
--Stephen
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: Inotify patch missed arch/x86_64/ia32/sys_ia32.c
2005-07-15 11:27 Inotify patch missed arch/x86_64/ia32/sys_ia32.c Stephen C. Tweedie
@ 2005-07-15 12:15 ` Andi Kleen
0 siblings, 0 replies; 2+ messages in thread
From: Andi Kleen @ 2005-07-15 12:15 UTC (permalink / raw)
To: Stephen C. Tweedie; +Cc: linux-kernel, David Woodhouse, Stephen Tweedie
On Fri, 15 Jul 2005 12:27:40 +0100
"Stephen C. Tweedie" <sct@redhat.com> wrote:
> Hi,
>
> The inotify patch just added a line
>
> + fsnotify_open(f->f_dentry);
>
> to sys_open, but it missed the x86_64 compatibility sys32_open()
> equivalent in arch/x86_64/ia32/sys_ia32.c.
... and probably missing in the other compat layers too.
> Andi, perhaps it's time to factor out the guts of sys_open from the flag
> munging to keep as much of that code as common as possible, and avoid
> this sort of maintenance problem in the future?
No problem from my side if someone does a patch, but on the other hand if
sys_open needs changes then likely all filp_open callers need too, and one would
better hope the patcher knows how to operate "grep -r" then. So it might
not buy much.
-Andi
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2005-07-15 12:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2005-07-15 11:27 Inotify patch missed arch/x86_64/ia32/sys_ia32.c Stephen C. Tweedie
2005-07-15 12:15 ` Andi Kleen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®