From: Tom Rini <trini@kernel.crashing.org>
To: randy_dunlap <rdunlap@xenotime.net>
Cc: sam@ravnborg.org, linux-kernel@vger.kernel.org, akpm@osdl.org,
stable@kernel.org
Subject: Re: [PATCH 2.6.13-rc3] kbuild: When checking depmod version, redirect stderr
Date: Fri, 15 Jul 2005 14:38:54 -0700 [thread overview]
Message-ID: <20050715213854.GY7741@smtp.west.cox.net> (raw)
In-Reply-To: <20050715142432.15f6752b.rdunlap@xenotime.net>
On Fri, Jul 15, 2005 at 02:24:32PM -0700, randy_dunlap wrote:
> On Fri, 15 Jul 2005 07:56:36 -0700 Tom Rini wrote:
>
> > When running depmod to check for the correct version number, extra
> > output we don't need to see, such as "depmod: QM_MODULES: Function not
> > implemented" may show up. Redirect stderr to /dev/null as the version
> > information that we do care about comes to stdout.
> >
> > Signed-off-by: Tom Rini <trini@kernel.crashing.org>
> >
> > diff --git a/Makefile b/Makefile
> > --- a/Makefile
> > +++ b/Makefile
> > @@ -875,7 +875,7 @@ modules_install: _modinst_ _modinst_post
> >
> > .PHONY: _modinst_
> > _modinst_:
> > - @if [ -z "`$(DEPMOD) -V | grep module-init-tools`" ]; then \
> > + @if [ -z "`$(DEPMOD) -V 2>/dev/null | grep module-init-tools`" ]; then \
> > echo "Warning: you may need to install module-init-tools"; \
> > echo "See http://www.codemonkey.org.uk/docs/post-halloween-2.6.txt";\
> > sleep 1; \
>
> Well, seeing "QM_MODULES" is a great indicator that someone is using
> modutils instead of module-init-tools, so I'd like to see it stay.
> IOW, I somewhat disagree with "extra output we don't need to see."
This shows up when building a 2.6 kernel with incorrect tools installed.
What shows up when building a 2.6 kernel on a 2.4 machine that's
properly setup to do both is "depmod: Can't open
/lib/modules/.../modules.dep for writing".
--
Tom Rini
http://gate.crashing.org/~trini/
next prev parent reply other threads:[~2005-07-15 21:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-07-15 14:56 Tom Rini
2005-07-15 21:24 ` randy_dunlap
2005-07-15 21:38 ` Tom Rini [this message]
2005-07-15 21:51 ` randy_dunlap
2005-07-17 21:04 ` Sam Ravnborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050715213854.GY7741@smtp.west.cox.net \
--to=trini@kernel.crashing.org \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rdunlap@xenotime.net \
--cc=sam@ravnborg.org \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®