[PATCH 2.6.13-rc3] kbuild: When checking depmod version, redirect stderr

[PATCH 2.6.13-rc3] kbuild: When checking depmod version, redirect stderr

[Tom Rini]

When running depmod to check for the correct version number, extra
output we don't need to see, such as "depmod: QM_MODULES: Function not
implemented" may show up.  Redirect stderr to /dev/null as the version
information that we do care about comes to stdout.

Signed-off-by: Tom Rini <trini@kernel.crashing.org>

diff --git a/Makefile b/Makefile
--- a/Makefile
+++ b/Makefile
@@ -875,7 +875,7 @@ modules_install: _modinst_ _modinst_post
 
 .PHONY: _modinst_
 _modinst_:
-	@if [ -z "`$(DEPMOD) -V | grep module-init-tools`" ]; then \
+	@if [ -z "`$(DEPMOD) -V 2>/dev/null | grep module-init-tools`" ]; then \
 		echo "Warning: you may need to install module-init-tools"; \
 		echo "See http://www.codemonkey.org.uk/docs/post-halloween-2.6.txt";\
 		sleep 1; \

-- 
Tom Rini
http://gate.crashing.org/~trini/

Re: [PATCH 2.6.13-rc3] kbuild: When checking depmod version, redirect stderr

[randy_dunlap]

On Fri, 15 Jul 2005 07:56:36 -0700 Tom Rini wrote:

> When running depmod to check for the correct version number, extra
> output we don't need to see, such as "depmod: QM_MODULES: Function not
> implemented" may show up.  Redirect stderr to /dev/null as the version
> information that we do care about comes to stdout.
> 
> Signed-off-by: Tom Rini <trini@kernel.crashing.org>
> 
> diff --git a/Makefile b/Makefile
> --- a/Makefile
> +++ b/Makefile
> @@ -875,7 +875,7 @@ modules_install: _modinst_ _modinst_post
>  
>  .PHONY: _modinst_
>  _modinst_:
> -	@if [ -z "`$(DEPMOD) -V | grep module-init-tools`" ]; then \
> +	@if [ -z "`$(DEPMOD) -V 2>/dev/null | grep module-init-tools`" ]; then \
>  		echo "Warning: you may need to install module-init-tools"; \
>  		echo "See http://www.codemonkey.org.uk/docs/post-halloween-2.6.txt";\
>  		sleep 1; \

Well, seeing "QM_MODULES" is a great indicator that someone is using
modutils instead of module-init-tools, so I'd like to see it stay.
IOW, I somewhat disagree with "extra output we don't need to see."

---
~Randy

Re: [PATCH 2.6.13-rc3] kbuild: When checking depmod version, redirect stderr

[Tom Rini]

On Fri, Jul 15, 2005 at 02:24:32PM -0700, randy_dunlap wrote:
> On Fri, 15 Jul 2005 07:56:36 -0700 Tom Rini wrote:
> 
> > When running depmod to check for the correct version number, extra
> > output we don't need to see, such as "depmod: QM_MODULES: Function not
> > implemented" may show up.  Redirect stderr to /dev/null as the version
> > information that we do care about comes to stdout.
> > 
> > Signed-off-by: Tom Rini <trini@kernel.crashing.org>
> > 
> > diff --git a/Makefile b/Makefile
> > --- a/Makefile
> > +++ b/Makefile
> > @@ -875,7 +875,7 @@ modules_install: _modinst_ _modinst_post
> >  
> >  .PHONY: _modinst_
> >  _modinst_:
> > -	@if [ -z "`$(DEPMOD) -V | grep module-init-tools`" ]; then \
> > +	@if [ -z "`$(DEPMOD) -V 2>/dev/null | grep module-init-tools`" ]; then \
> >  		echo "Warning: you may need to install module-init-tools"; \
> >  		echo "See http://www.codemonkey.org.uk/docs/post-halloween-2.6.txt";\
> >  		sleep 1; \
> 
> Well, seeing "QM_MODULES" is a great indicator that someone is using
> modutils instead of module-init-tools, so I'd like to see it stay.
> IOW, I somewhat disagree with "extra output we don't need to see."

This shows up when building a 2.6 kernel with incorrect tools installed.
What shows up when building a 2.6 kernel on a 2.4 machine that's
properly setup to do both is "depmod: Can't open
/lib/modules/.../modules.dep for writing".

-- 
Tom Rini
http://gate.crashing.org/~trini/

Re: [PATCH 2.6.13-rc3] kbuild: When checking depmod version, redirect stderr

[randy_dunlap]

On Fri, 15 Jul 2005 14:38:54 -0700 Tom Rini wrote:

> On Fri, Jul 15, 2005 at 02:24:32PM -0700, randy_dunlap wrote:
> > On Fri, 15 Jul 2005 07:56:36 -0700 Tom Rini wrote:
> > 
> > > When running depmod to check for the correct version number, extra
> > > output we don't need to see, such as "depmod: QM_MODULES: Function not
> > > implemented" may show up.  Redirect stderr to /dev/null as the version
> > > information that we do care about comes to stdout.
> > > 
> > > Signed-off-by: Tom Rini <trini@kernel.crashing.org>
> > > 
> > > diff --git a/Makefile b/Makefile
> > > --- a/Makefile
> > > +++ b/Makefile
> > > @@ -875,7 +875,7 @@ modules_install: _modinst_ _modinst_post
> > >  
> > >  .PHONY: _modinst_
> > >  _modinst_:
> > > -	@if [ -z "`$(DEPMOD) -V | grep module-init-tools`" ]; then \
> > > +	@if [ -z "`$(DEPMOD) -V 2>/dev/null | grep module-init-tools`" ]; then \
> > >  		echo "Warning: you may need to install module-init-tools"; \
> > >  		echo "See http://www.codemonkey.org.uk/docs/post-halloween-2.6.txt";\
> > >  		sleep 1; \
> > 
> > Well, seeing "QM_MODULES" is a great indicator that someone is using
> > modutils instead of module-init-tools, so I'd like to see it stay.
> > IOW, I somewhat disagree with "extra output we don't need to see."
> 
> This shows up when building a 2.6 kernel with incorrect tools installed.
> What shows up when building a 2.6 kernel on a 2.4 machine that's
> properly setup to do both is "depmod: Can't open
> /lib/modules/.../modules.dep for writing".

I see.  Thanks for clarifying.  No problem then (with the patch).

---
~Randy

Re: kbuild: When checking depmod version, redirect stderr

[Sam Ravnborg]

On Fri, Jul 15, 2005 at 07:56:36AM -0700, Tom Rini wrote:
> When running depmod to check for the correct version number, extra
> output we don't need to see, such as "depmod: QM_MODULES: Function not
> implemented" may show up.  Redirect stderr to /dev/null as the version
> information that we do care about comes to stdout.

Applied, thanks.

	Sam