From: Matt Mackall <mpm@selenic.com>
To: "David S. Miller" <davem@davemloft.net>
Cc: bunk@stusta.de, jgarzik@pobox.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [2.6 patch] NETCONSOLE must depend on INET
Date: Tue, 26 Jul 2005 16:20:43 -0700 [thread overview]
Message-ID: <20050726232043.GB7425@waste.org> (raw)
In-Reply-To: <20050719.140104.68160812.davem@davemloft.net>
On Tue, Jul 19, 2005 at 02:01:04PM -0700, David S. Miller wrote:
> From: Adrian Bunk <bunk@stusta.de>
> Date: Tue, 19 Jul 2005 20:29:19 +0200
>
> > NETCONSOLE=y and INET=n results in the following compile error:
>
> Also applied, thanks Adrian.
I should have been cc:ed on this.
This problem also exists in PKTGEN. And this fix is incorrect as
neither is dependent on the IP part of the networking stack in any
substantive way. The right fix is to make inet_aton available outside
of CONFIG_INET (preferred) or making private copies of inet_aton.
--
Mathematics is the supreme nostalgia of our time.
next prev parent reply other threads:[~2005-07-26 23:21 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-07-19 18:29 Adrian Bunk
2005-07-19 21:01 ` David S. Miller
2005-07-26 23:20 ` Matt Mackall [this message]
2005-07-26 23:32 ` David S. Miller
2005-07-26 23:58 ` Matt Mackall
2005-07-27 0:03 ` David S. Miller
2005-07-27 2:36 ` Matt Mackall
2005-07-27 2:53 ` David S. Miller
2005-07-27 20:19 ` David S. Miller
2005-07-27 20:46 ` Matt Mackall
2005-07-27 21:13 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050726232043.GB7425@waste.org \
--to=mpm@selenic.com \
--cc=bunk@stusta.de \
--cc=davem@davemloft.net \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®