From: Matt Mackall <mpm@selenic.com>
To: "David S. Miller" <davem@davemloft.net>
Cc: bunk@stusta.de, jgarzik@pobox.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [2.6 patch] NETCONSOLE must depend on INET
Date: Tue, 26 Jul 2005 16:58:24 -0700 [thread overview]
Message-ID: <20050726235824.GN12006@waste.org> (raw)
In-Reply-To: <20050726.163202.119887768.davem@davemloft.net>
On Tue, Jul 26, 2005 at 04:32:02PM -0700, David S. Miller wrote:
> From: Matt Mackall <mpm@selenic.com>
> Date: Tue, 26 Jul 2005 16:20:43 -0700
>
> > This problem also exists in PKTGEN. And this fix is incorrect as
> > neither is dependent on the IP part of the networking stack in any
> > substantive way. The right fix is to make inet_aton available outside
> > of CONFIG_INET (preferred) or making private copies of inet_aton.
>
> Adrian posted a fix, you whine, that's why Adrian's fix
> went in :-)
Adrian's fix is the moral equivalent of throwing in a cast to shut up
a compiler warning for a legitimate bug.
> More seriously, please submit a version of whatever you
> believe to be the more correct fix so it can be reviewed
> and integrated.
Do you have a preferred location to put this function or
shall I invent one?
--
Mathematics is the supreme nostalgia of our time.
next prev parent reply other threads:[~2005-07-27 0:01 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-07-19 18:29 Adrian Bunk
2005-07-19 21:01 ` David S. Miller
2005-07-26 23:20 ` Matt Mackall
2005-07-26 23:32 ` David S. Miller
2005-07-26 23:58 ` Matt Mackall [this message]
2005-07-27 0:03 ` David S. Miller
2005-07-27 2:36 ` Matt Mackall
2005-07-27 2:53 ` David S. Miller
2005-07-27 20:19 ` David S. Miller
2005-07-27 20:46 ` Matt Mackall
2005-07-27 21:13 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050726235824.GN12006@waste.org \
--to=mpm@selenic.com \
--cc=bunk@stusta.de \
--cc=davem@davemloft.net \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®