mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@osdl.org>
To: Adrian Bunk <bunk@stusta.de>
Cc: linux-kernel@vger.kernel.org, Christoph Lameter <christoph@lameter.com>
Subject: Re: [2.6 patch] mm/slab: unexport kmem_cache_alloc_node
Date: Wed, 27 Jul 2005 13:03:55 -0700	[thread overview]
Message-ID: <20050727130355.08a534b7.akpm@osdl.org> (raw)
In-Reply-To: <20050727195107.GC29092@stusta.de>

Adrian Bunk <bunk@stusta.de> wrote:
>
> I didn't find any modular usage of kmem_cache_alloc_node.
> 
> Signed-off-by: Adrian Bunk <bunk@stusta.de>
> 
> ---
> 
> This patch was already sent on:
> - 2 Jul 2005
> - 21 Jun 2005
> - 30 May 2005
> - 15 May 2005

Yeah, I've been ducking that one.

> --- linux-2.6.11-mm1-full/mm/slab.c.old	2005-03-06 15:40:38.000000000 +0100
> +++ linux-2.6.11-mm1-full/mm/slab.c	2005-03-06 15:41:06.000000000 +0100
> @@ -2431,7 +2440,6 @@
>  					__builtin_return_address(0));
>  	return objp;
>  }
> -EXPORT_SYMBOL(kmem_cache_alloc_node);
>  
>  #endif

Even though we don't currently have in-module users, we probably will do so
soon and it's a part of the slab API and the slab API is exported to
modules.  I don't see much point in partially-exporting the API and
applying a patch which we'll soon revert.

Christoph?

  reply	other threads:[~2005-07-27 20:10 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-07-27 19:51 Adrian Bunk
2005-07-27 20:03 ` Andrew Morton [this message]
2005-07-27 20:19   ` Christoph Lameter
2005-07-27 20:50     ` Adrian Bunk
2005-07-27 20:55       ` Christoph Lameter
  -- strict thread matches above, loose matches on Subject: below --
2006-02-20 22:36 Adrian Bunk
2006-02-21  1:02 ` Andrew Morton
2005-07-02 11:37 Adrian Bunk
2005-06-20 23:43 Adrian Bunk
2005-05-30  0:28 Adrian Bunk
2005-05-15 13:28 Adrian Bunk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050727130355.08a534b7.akpm@osdl.org \
    --to=akpm@osdl.org \
    --cc=bunk@stusta.de \
    --cc=christoph@lameter.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®