From: Christoph Lameter <christoph@lameter.com>
To: Andrew Morton <akpm@osdl.org>
Cc: Adrian Bunk <bunk@stusta.de>, linux-kernel@vger.kernel.org
Subject: Re: [2.6 patch] mm/slab: unexport kmem_cache_alloc_node
Date: Wed, 27 Jul 2005 13:19:00 -0700 (PDT) [thread overview]
Message-ID: <Pine.LNX.4.62.0507271317400.12883@graphe.net> (raw)
In-Reply-To: <20050727130355.08a534b7.akpm@osdl.org>
On Wed, 27 Jul 2005, Andrew Morton wrote:
> > return objp;
> > }
> > -EXPORT_SYMBOL(kmem_cache_alloc_node);
> >
> > #endif
>
> Even though we don't currently have in-module users, we probably will do so
> soon and it's a part of the slab API and the slab API is exported to
> modules. I don't see much point in partially-exporting the API and
> applying a patch which we'll soon revert.
>
> Christoph?
>
I fully agree. Drivers will have to use that call in the future in order
to properly place their control structures. The e1000 in your tree already
does so and may be compiled as a module. Thus applying this patch will
break mm.
next prev parent reply other threads:[~2005-07-27 20:20 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-07-27 19:51 Adrian Bunk
2005-07-27 20:03 ` Andrew Morton
2005-07-27 20:19 ` Christoph Lameter [this message]
2005-07-27 20:50 ` Adrian Bunk
2005-07-27 20:55 ` Christoph Lameter
-- strict thread matches above, loose matches on Subject: below --
2006-02-20 22:36 Adrian Bunk
2006-02-21 1:02 ` Andrew Morton
2005-07-02 11:37 Adrian Bunk
2005-06-20 23:43 Adrian Bunk
2005-05-30 0:28 Adrian Bunk
2005-05-15 13:28 Adrian Bunk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Pine.LNX.4.62.0507271317400.12883@graphe.net \
--to=christoph@lameter.com \
--cc=akpm@osdl.org \
--cc=bunk@stusta.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®