[patch 1/2] doc: describe Kbuild pitfall

[patch 1/2] doc: describe Kbuild pitfall

[blaisorblade]

From: Paolo 'Blaisorblade' Giarrusso <blaisorblade@yahoo.it>
Cc: Sam Ravnborg <sam@ravnborg.org>

Whitespace is significant for make, and I just fought against this... so
please apply this patch.

I'm resending since this hasn't been applied for a long time.

Signed-off-by: Paolo 'Blaisorblade' Giarrusso <blaisorblade@yahoo.it>
---

 linux-2.6.git-paolo/Documentation/kbuild/makefiles.txt |    6 ++++++
 1 files changed, 6 insertions(+)

diff -puN Documentation/kbuild/makefiles.txt~doc-add-pitfall Documentation/kbuild/makefiles.txt
--- linux-2.6.git/Documentation/kbuild/makefiles.txt~doc-add-pitfall	2005-07-28 17:47:08.000000000 +0200
+++ linux-2.6.git-paolo/Documentation/kbuild/makefiles.txt	2005-07-28 17:47:08.000000000 +0200
@@ -872,7 +872,13 @@ When kbuild executes the following steps
 	Assignments to $(targets) are without $(obj)/ prefix.
 	if_changed may be used in conjunction with custom commands as
 	defined in 6.7 "Custom kbuild commands".
+
 	Note: It is a typical mistake to forget the FORCE prerequisite.
+	Another pitfall that bit me once is that whitespace is sometimes
+	significant; for instance, the below will fail (note the extra space
+	after the comma):
+		target: source(s) FORCE
+			$(call if_changed, ld/objcopy/gzip)
 
     ld
 	Link target. Often LDFLAGS_$@ is used to set specific options to ld.
_

Re: [patch 1/2] doc: describe Kbuild pitfall

[Sam Ravnborg]

On Thu, Jul 28, 2005 at 05:56:17PM +0200, blaisorblade@yahoo.it wrote:
> 
> From: Paolo 'Blaisorblade' Giarrusso <blaisorblade@yahoo.it>
> Cc: Sam Ravnborg <sam@ravnborg.org>
> 
> Whitespace is significant for make, and I just fought against this... so
> please apply this patch.
> 
> I'm resending since this hasn't been applied for a long time.
I've lost it somewhere. Applied.

	Sam