From: Andrew Morton <akpm@osdl.org>
To: Mel Gorman <mel@csn.ul.ie>
Cc: linux-kernel@vger.kernel.org
Subject: Re: How to reclaim inode pages on demand
Date: Mon, 8 Aug 2005 16:08:44 -0700 [thread overview]
Message-ID: <20050808160844.04d1f7ac.akpm@osdl.org> (raw)
In-Reply-To: <Pine.LNX.4.58.0508081650160.26013@skynet>
Mel Gorman <mel@csn.ul.ie> wrote:
>
> Hi,
>
> I am working on a direct reclaim strategy to free up large blocks of
> contiguous pages. The part I have is working fine, but I am finding a
> hundreds of pages that are being used for inodes that I need to reclaim. I
> tried purging the inode lists using a variation of prune_icache() but it
> is not working out.
>
> Given a struct page, that one knows is an inode, can anyone suggest the
> best way to find the inode using it and free it?
Simple answer: invalidate_mapping_pages(page->mapping, start, end).
Problem: races. If you pick a random page up off the LRU and start playing
with its mapping, what stops that mapping from getting freed under your
feet?
If the caller has a ref on the inode (say, you came in via a syscall
against an fd) then fine.
But if you picked the page up off the LRU then to avoid super-rare oopses
you'll need to pin the address_space somehow. One way is to
a) lock the page, which pins the address_space.
b) check that page->mapping is still non-NULL. Bale if it is.
c) bump page->mapping->host->i_count
d) unlock the page
e) diddle away with the address_space.
f) iput() the inode.
But beware that iput() can do a *ton* of stuff, so you need to be not
holding any locks and to not be called from any fancy contexts.
next prev parent reply other threads:[~2005-08-08 23:10 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-08-08 15:52 Mel Gorman
2005-08-08 16:08 ` Jörn Engel
2005-08-08 16:23 ` Mel Gorman
2005-08-08 23:08 ` Andrew Morton [this message]
2005-08-10 16:32 ` Mel Gorman
2005-08-10 17:17 ` Andrew Morton
2005-08-10 17:27 ` Mel Gorman
2005-08-10 17:40 ` Andrew Morton
2005-08-10 17:51 ` Mel Gorman
2005-08-10 17:52 ` Andrew Morton
2005-08-10 17:50 ` Dave Hansen
2005-08-10 17:59 ` Mel Gorman
2005-08-11 3:08 ` Magnus Damm
2005-08-11 4:44 ` Andrew Morton
2005-08-11 5:43 ` Magnus Damm
2005-08-11 9:09 ` Coywolf Qi Hunt
2005-08-11 14:09 ` Hugh Dickins
2005-08-09 4:06 ` Rik van Riel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050808160844.04d1f7ac.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mel@csn.ul.ie \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®