mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Mel Gorman <mel@csn.ul.ie>
To: Dave Hansen <haveblue@us.ibm.com>
Cc: Andrew Morton <akpm@osdl.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: How to reclaim inode pages on demand
Date: Wed, 10 Aug 2005 18:59:12 +0100 (IST)	[thread overview]
Message-ID: <Pine.LNX.4.58.0508101851520.11984@skynet> (raw)
In-Reply-To: <1123696225.15970.10.camel@localhost>

On Wed, 10 Aug 2005, Dave Hansen wrote:

> On Wed, 2005-08-10 at 18:27 +0100, Mel Gorman wrote:
> > I later linearly scan the mem_map looking for pages that can be freed up
> > (usually LRU pages). I was expecting any page with PG_inode set to have a
> > page->mapping but not all of them do. It is the pages without a ->mapping
> > that are confusing the hell out of me.
>
> How about putting a check for PG_inode and a periodic dump_stack()
> wherever page->mapping is cleared?  That should at least let you catch
> the culprit who is clearing them. __remove_from_page_cache() is the only
> real place I see this being done.
>

Will do, it might shed some light on whats happening.

> Are you remembering to clean PG_inode when a page is freed?

Yes, I was using the allocator to count how many inode-related pages there
were in the system. The answer was lots, another reason why I'm thinking
that I picked the worst possible benchmark to test this stuff with.

> Perhaps
> it's allocated for the page cache, reclaimed, returned to the allocator,
> and reallocated as anonymous memory where you're seeing the null
> ->mapping.  Might want to check for PG_inode in free_pages_check().
>

I am 99.99% certain I make that check but I can't double check the code
until late in the weekend.

-- 
Mel Gorman
Part-time Phd Student                          Java Applications Developer
University of Limerick                         IBM Dublin Software Lab

  reply	other threads:[~2005-08-10 17:59 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-08-08 15:52 Mel Gorman
2005-08-08 16:08 ` Jörn Engel
2005-08-08 16:23   ` Mel Gorman
2005-08-08 23:08 ` Andrew Morton
2005-08-10 16:32   ` Mel Gorman
2005-08-10 17:17     ` Andrew Morton
2005-08-10 17:27       ` Mel Gorman
2005-08-10 17:40         ` Andrew Morton
2005-08-10 17:51           ` Mel Gorman
2005-08-10 17:52             ` Andrew Morton
2005-08-10 17:50         ` Dave Hansen
2005-08-10 17:59           ` Mel Gorman [this message]
2005-08-11  3:08       ` Magnus Damm
2005-08-11  4:44         ` Andrew Morton
2005-08-11  5:43           ` Magnus Damm
2005-08-11  9:09           ` Coywolf Qi Hunt
2005-08-11 14:09             ` Hugh Dickins
2005-08-09  4:06 ` Rik van Riel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Pine.LNX.4.58.0508101851520.11984@skynet \
    --to=mel@csn.ul.ie \
    --cc=akpm@osdl.org \
    --cc=haveblue@us.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®