mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@mellanox.co.il>
To: Hugh Dickins <hugh@veritas.com>
Cc: Roland Dreier <roland@topspin.com>,
	openib-general@openib.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH repost] PROT_DONTCOPY: ifiniband uverbs fork support
Date: Wed, 10 Aug 2005 11:30:07 +0300	[thread overview]
Message-ID: <20050810083007.GD2405@mellanox.co.il> (raw)
In-Reply-To: <Pine.LNX.4.61.0508091759050.14886@goblin.wat.veritas.com>

Quoting r. Hugh Dickins <hugh@veritas.com>:
> > > The other reason I dislike the patch is that the problem it fixes is
> > > an old one, and I'd much rather have get_user_pages fix it for itself,
> > 
> > Please note that the problem this attempts to solve is not limited
> > to pages locked by get_user_pages: in an infiniband userspace initiator,
> > a hardware page is mapped into process memory and must not be inherited
> > by a child processes, otherwise hardware protection breaks.
> 
> Interesting.
> 
> But (correct me if I'm wrong, I know nothing about InfiniBand userspace
> initiators) that would be done by a driver, which can set VM_DONTCOPY
> on the vma, without us having to extend the mprotect or madvise API

Roland, Hugh here proposes setting VM_DONTCOPY on user-mapped PIO
memory from driver on mmap, to protect against child process
corrupting parent's user access region.

IIRC, we used to set this bit, but it was removed later - could you please
clarify why? Do you think its a good idea to restore this behaviour?

-- 
MST

  reply	other threads:[~2005-08-10  8:27 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-07-19 16:55 [PATCH] " Michael S. Tsirkin
2005-07-25 17:19 ` [PATCH repost] PROT_DONTCOPY: ifiniband uverbs " Michael S. Tsirkin
2005-07-26 12:30   ` Hugh Dickins
2005-07-26 13:35     ` Michael S. Tsirkin
2005-08-09 18:13       ` Hugh Dickins
2005-08-10  8:30         ` Michael S. Tsirkin [this message]
2005-08-10  8:39         ` [openib-general] " Gleb Natapov
2005-08-10 13:22           ` Hugh Dickins
2005-08-10 13:26             ` Gleb Natapov
2005-08-10 15:27               ` Hugh Dickins
2005-08-11  8:02                 ` Gleb Natapov
2005-08-11 14:04                   ` Hugh Dickins
2005-08-11 14:07                     ` Gleb Natapov
2005-08-11 14:17                       ` Hugh Dickins
2005-08-11 14:11                     ` Michael S. Tsirkin
2005-08-15 16:37                   ` Bill Jordan
2005-08-16  7:52                     ` Gleb Natapov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050810083007.GD2405@mellanox.co.il \
    --to=mst@mellanox.co.il \
    --cc=hugh@veritas.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=openib-general@openib.org \
    --cc=roland@topspin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome