* [PATCH 2.6.12.5]fix gl_skb/skb type error in genelink driver in usbnet in 2.6
@ 2005-08-22 6:02 lepton
2005-08-22 23:56 ` David Brownell
0 siblings, 1 reply; 2+ messages in thread
From: lepton @ 2005-08-22 6:02 UTC (permalink / raw)
To: dbrownell; +Cc: linux-kernel
Hi!
I think there is a type error when port genelink driver to 2.6..
With this error, a linux host will panic when it link with a windows
host.
See the following patch.
diff -pruNX linux-2.6-curr/Documentation/dontdiff linux-2.6-curr/drivers/usb/net/usbnet.c linux-2.6-curr-lepton/drivers/usb/net/usbnet.c
--- linux-2.6-curr/drivers/usb/net/usbnet.c 2005-06-30 07:00:53.000000000 +0800
+++ linux-2.6-curr-lepton/drivers/usb/net/usbnet.c 2005-08-22 13:55:18.000000000 +0800
@@ -1922,7 +1922,7 @@ static int genelink_rx_fixup (struct usb
// copy the packet data to the new skb
memcpy(skb_put(gl_skb, size), packet->packet_data, size);
- skb_return (dev, skb);
+ skb_return (dev, gl_skb);
}
// advance to the next packet
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH 2.6.12.5]fix gl_skb/skb type error in genelink driver in usbnet in 2.6
2005-08-22 6:02 [PATCH 2.6.12.5]fix gl_skb/skb type error in genelink driver in usbnet in 2.6 lepton
@ 2005-08-22 23:56 ` David Brownell
0 siblings, 0 replies; 2+ messages in thread
From: David Brownell @ 2005-08-22 23:56 UTC (permalink / raw)
To: ytht.net; +Cc: linux-kernel
> I think there is a type error when port genelink driver to 2.6..
> With this error, a linux host will panic when it link with a windows
> host.
>
> See the following patch.
>
Looks right to me; thanks! Would you happen to know if this
GL620a chip is still manufactured?
If this oops fix doesn't make 2.6.13, I'll roll this change into
the upcoming split of "usbnet" into eight minidrivers around a
shared core library.
- Dave
> --- linux-2.6-curr/drivers/usb/net/usbnet.c 2005-06-30 07:00:53.000000000 +0800
> +++ linux-2.6-curr-lepton/drivers/usb/net/usbnet.c 2005-08-22 13:55:18.000000000 +0800
> @@ -1922,7 +1922,7 @@ static int genelink_rx_fixup (struct usb
>
> // copy the packet data to the new skb
> memcpy(skb_put(gl_skb, size), packet->packet_data, size);
> - skb_return (dev, skb);
> + skb_return (dev, gl_skb);
> }
>
> // advance to the next packet
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2005-08-22 23:56 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2005-08-22 6:02 [PATCH 2.6.12.5]fix gl_skb/skb type error in genelink driver in usbnet in 2.6 lepton
2005-08-22 23:56 ` David Brownell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®