From: Dominik Brodowski <linux@dominikbrodowski.net>
To: Marcelo Tosatti <marcelo.tosatti@cyclades.com>
Cc: linux-ppc-embedded <linuxppc-embedded@ozlabs.org>,
linux-kernel@vger.kernel.org,
Russell King <rmk+lkml@arm.linux.org.uk>,
Dan Malek <dan@embeddededge.com>,
Pantelis Antoniou <panto@intracom.gr>
Subject: Re: [PATCH] MPC8xx PCMCIA driver
Date: Thu, 1 Sep 2005 10:53:19 +0200 [thread overview]
Message-ID: <20050901085319.GB6285@isilmar.linta.de> (raw)
In-Reply-To: <20050830024840.GA5381@dmt.cnet>
Hi,
On Mon, Aug 29, 2005 at 11:48:40PM -0300, Marcelo Tosatti wrote:
> Russell: The driver is using pccard_nonstatic_ops for card window
> management, even though the driver its marked SS_STATIC_MAP (using
> mem->static_map).
This is obviously broken. Where does it fail if pccard_static_ops is used?
> +typedef struct {
> + u_int regbit;
> + u_int eventbit;
> +} event_table_t;
No typedefs, please.
Dominik
next prev parent reply other threads:[~2005-09-01 8:53 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-08-30 2:48 Marcelo Tosatti
2005-08-30 3:39 ` Jeff Garzik
2005-08-30 3:53 ` Marcelo Tosatti
2005-08-30 4:32 ` Paul Mackerras
2005-08-30 15:07 ` Marcelo Tosatti
2005-08-30 4:33 ` Jeff Garzik
2005-08-30 7:06 ` Russell King
2005-09-01 8:53 ` Dominik Brodowski [this message]
2005-09-01 11:44 ` Magnus Damm
2005-09-01 14:51 ` Marcelo Tosatti
2005-09-14 14:11 ` Marcelo Tosatti
2005-09-14 14:27 ` Dominik Brodowski
2005-09-14 18:21 ` Marcelo Tosatti
2005-09-14 18:46 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050901085319.GB6285@isilmar.linta.de \
--to=linux@dominikbrodowski.net \
--cc=dan@embeddededge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-embedded@ozlabs.org \
--cc=marcelo.tosatti@cyclades.com \
--cc=panto@intracom.gr \
--cc=rmk+lkml@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®