mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "David S. Miller" <davem@davemloft.net>
To: nickpiggin@yahoo.com.au
Cc: Linux-Kernel@vger.kernel.org, dipankar@in.ibm.com
Subject: Re: [PATCH 4/5] atomic: dec_and_lock use cmpxchg
Date: Wed, 14 Sep 2005 09:24:41 -0700 (PDT)	[thread overview]
Message-ID: <20050914.092441.87955714.davem@davemloft.net> (raw)
In-Reply-To: <432839F1.5020907@yahoo.com.au>

From: Nick Piggin <nickpiggin@yahoo.com.au>
Date: Thu, 15 Sep 2005 00:55:45 +1000

> I noticed David posted a patch to do something similar the
> other day. With a generic atomic_cmpxchg available, such a
> patch is no longer objectionable to those architectures
> that don't #define __HAVE_ARCH_CMPXCHG
> 
> Do we want this David? Any other architecture have a super
> optimised atomic_dec_and_lock that surpasses this
> implementation?

I talked to Linus about my patch and he made the good point that the
Alpha optimization is very valid (it avoids loading the GP and other
stuff by doing that fancy assembler entry point).  So we decided that
we'd make the cmpxchg() generic version, but make moving over to that
gradual instead of mandatorily forcing everyone to use the new thing.

So, for example, we'd convert sparc64 (because I want to) and the
architectures using the exact same ppc64 C code, but leave the others
alone.  It'd be up to the remaining platform's maintainers to move
over if they wanted to.

I'll submit that updated patch to him later today.

  parent reply	other threads:[~2005-09-14 16:24 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-09-14 14:48 [PATCH 1/5] atomic: introduce atomic_cmpxchg Nick Piggin
2005-09-14 14:49 ` [PATCH 2/5] atomic: introduce atomic_inc_not_zero Nick Piggin
2005-09-14 14:51   ` [PATCH 3/5] rcu file: use atomic primitives Nick Piggin
2005-09-14 14:55     ` [PATCH 4/5] atomic: dec_and_lock use cmpxchg Nick Piggin
2005-09-14 15:01       ` [PATCH 5/5] remove HAVE_ARCH_CMPXCHG Nick Piggin
2005-09-14 16:31         ` Roman Zippel
2005-09-14 16:49           ` Nick Piggin
2005-09-14 17:59             ` David S. Miller
2005-09-14 22:03             ` Russell King
2005-09-14 22:26               ` David S. Miller
2005-09-15  7:10                 ` Russell King
2005-09-15 13:08         ` Alan Cox
2005-09-14 15:20       ` [PATCH 4/5] atomic: dec_and_lock use cmpxchg Nick Piggin
2005-09-14 16:24       ` David S. Miller [this message]
2005-09-14 16:52         ` Nick Piggin
2005-09-17  0:05           ` David S. Miller
2005-09-14 16:16   ` [PATCH 2/5] atomic: introduce atomic_inc_not_zero Roman Zippel
2005-09-14 16:44     ` Nick Piggin
2005-09-14 17:04       ` Nick Piggin
2005-09-14 17:18       ` Roman Zippel
2005-09-14 22:00         ` Russell King
2005-09-14 22:10           ` Roman Zippel
2005-09-14 22:21             ` Russell King
2005-09-15  1:51               ` Nick Piggin
2005-09-17  1:15                 ` Roman Zippel
2005-09-17  6:36                   ` Andrew Morton
2005-09-17 10:01                     ` Roman Zippel
2005-09-17  7:19                   ` David S. Miller
2005-09-17  7:34                   ` Dipankar Sarma
2005-09-18  8:08                   ` Nick Piggin
2005-09-17  0:59               ` Roman Zippel
2005-09-17  7:18                 ` David S. Miller
2005-09-17  7:27                   ` Russell King
2005-09-18  6:03                     ` David S. Miller
2005-09-14 15:17 ` [PATCH 1/5] atomic: introduce atomic_cmpxchg Russell King
2005-09-14 15:22   ` Nick Piggin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050914.092441.87955714.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=Linux-Kernel@vger.kernel.org \
    --cc=dipankar@in.ibm.com \
    --cc=nickpiggin@yahoo.com.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®