* [PATCH]: Missing acct/mm calls in compat_do_execve()
@ 2005-09-14 18:56 David S. Miller
0 siblings, 0 replies; only message in thread
From: David S. Miller @ 2005-09-14 18:56 UTC (permalink / raw)
To: linux-kernel; +Cc: akpm, torvalds
As I do periodically, I checked to see how far out of sync
compat_do_execve() has gotten from do_execve(). And as usual there
was some missing stuff in the former. Perhaps we need some tighter
consolidation of these two routines to make this less likely to happen
in the future.
Anyways, on the success path of compat_do_execve() we forget
to call acct_update_integrals() and update_mem_hiwater(), as
is done in do_execve().
Signed-off-by: David S. Miller <davem@davemloft.net>
diff --git a/fs/compat.c b/fs/compat.c
--- a/fs/compat.c
+++ b/fs/compat.c
@@ -44,6 +44,8 @@
#include <linux/nfsd/syscall.h>
#include <linux/personality.h>
#include <linux/rwsem.h>
+#include <linux/acct.h>
+#include <linux/mm.h>
#include <net/sock.h> /* siocdevprivate_ioctl */
@@ -1487,6 +1489,8 @@ int compat_do_execve(char * filename,
/* execve success */
security_bprm_free(bprm);
+ acct_update_integrals(current);
+ update_mem_hiwater(current);
kfree(bprm);
return retval;
}
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2005-09-14 18:56 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2005-09-14 18:56 [PATCH]: Missing acct/mm calls in compat_do_execve() David S. Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®