Re: 2.6.14-rc1 on ATI hangs when executing _STA and _INI methods

Re: 2.6.14-rc1 on ATI hangs when executing _STA and _INI methods

[Chuck Ebbert]

In-Reply-To: <Pine.LNX.4.58.0509141521370.26803@g5.osdl.org>

On Wed, 14 Sep 2005 at 15:27:19 -0700 (PDT), Linus Torvalds wrote:

> >     [PATCH] x86-64: i386/x86-64: Fix time going twice as fast problem on ATI Xpress chipsets
> > 
> > Passing enable_timer_pin_1 as a kernel boot parameter doesn't help,
> > but this patch does:
> 
> Ok. That patch has been one big pain, and was clearly totally half-baked.  
> I think I'll disable the automated checks, since they are clearly wrong.

 Well I never meant it to be merged, but Andi picked it up from Bugzilla
bug #3927, added some bugs of his own, then sent it on.

 This bug was mine, though: just checking for vendor == ATI was a bad idea.
Current earlyquirk code actually looks at PCI bridges instead of host bridge,
so to get an accurate test I guess it needs to look at PCI dev 00:00.0 and
check both vendor and device ID.  As new models come out they will have to
be added one by one.

 With a real understanding of what's going on maybe this problem can be solved
reliably with generic code, but it's beyond me...
__
Chuck
Subliminal URL: www.sluggy.com/daily.php?date=050905

Re: 2.6.14-rc1 on ATI hangs when executing _STA and _INI methods

[Peter Osterlund]

Linus Torvalds <torvalds@osdl.org> writes:

> On Wed, 15 Sep 2005, Peter Osterlund wrote:
> > 
> > My Compaq Presario R3057EA hangs during ACPI initialization. The last
> > message is "Executing all Device _STA and _INI methods". git bisect
> > told me that:
> > 
> >   66759a01adbfe8828dd063e32cf5ed3f46696181 is first bad commit
> >   diff-tree 66759a01adbfe8828dd063e32cf5ed3f46696181 (from 049cdefe19f95b67b06b70915cd8e4ae7173337a)
> >   Author: Chuck Ebbert <76306.1226@compuserve.com>
> >   Date:   Mon Sep 12 18:49:25 2005 +0200
> > 
> >     [PATCH] x86-64: i386/x86-64: Fix time going twice as fast problem on ATI Xpress chipsets
> > 
> > Passing enable_timer_pin_1 as a kernel boot parameter doesn't help,
> > but this patch does:
> 
> Ok. That patch has been one big pain, and was clearly totally half-baked.  
> I think I'll disable the automated checks, since they are clearly wrong.
> You can still enable it manually with a kernel command line.
> 
> So something like this.. I assume this works for you?

Yes it does.

-- 
Peter Osterlund - petero2@telia.com
http://web.telia.com/~u89404340

Re: 2.6.14-rc1 on ATI hangs when executing _STA and _INI methods

[Linus Torvalds]

On Wed, 15 Sep 2005, Peter Osterlund wrote:
> 
> My Compaq Presario R3057EA hangs during ACPI initialization. The last
> message is "Executing all Device _STA and _INI methods". git bisect
> told me that:
> 
>   66759a01adbfe8828dd063e32cf5ed3f46696181 is first bad commit
>   diff-tree 66759a01adbfe8828dd063e32cf5ed3f46696181 (from 049cdefe19f95b67b06b70915cd8e4ae7173337a)
>   Author: Chuck Ebbert <76306.1226@compuserve.com>
>   Date:   Mon Sep 12 18:49:25 2005 +0200
> 
>     [PATCH] x86-64: i386/x86-64: Fix time going twice as fast problem on ATI Xpress chipsets
> 
> Passing enable_timer_pin_1 as a kernel boot parameter doesn't help,
> but this patch does:

Ok. That patch has been one big pain, and was clearly totally half-baked.  
I think I'll disable the automated checks, since they are clearly wrong.
You can still enable it manually with a kernel command line.

So something like this.. I assume this works for you?

		Linus

----
diff --git a/arch/i386/kernel/acpi/earlyquirk.c b/arch/i386/kernel/acpi/earlyquirk.c
--- a/arch/i386/kernel/acpi/earlyquirk.c
+++ b/arch/i386/kernel/acpi/earlyquirk.c
@@ -7,7 +7,6 @@
 #include <linux/pci.h>
 #include <asm/pci-direct.h>
 #include <asm/acpi.h>
-#include <asm/apic.h>
 
 static int __init check_bridge(int vendor, int device)
 {
@@ -16,15 +15,6 @@ static int __init check_bridge(int vendo
 	if (vendor == PCI_VENDOR_ID_NVIDIA) {
 		acpi_skip_timer_override = 1;
 	}
-#ifdef CONFIG_X86_LOCAL_APIC
-	/*
-	 * ATI IXP chipsets get double timer interrupts.
-	 * For now just do this for all ATI chipsets.
- 	 * FIXME: this needs to be checked for the non ACPI case too.
-	 */
-	if (vendor == PCI_VENDOR_ID_ATI)
-		disable_timer_pin_1 = 1;
-#endif
 	return 0;
 }
 
diff --git a/arch/x86_64/kernel/io_apic.c b/arch/x86_64/kernel/io_apic.c
--- a/arch/x86_64/kernel/io_apic.c
+++ b/arch/x86_64/kernel/io_apic.c
@@ -299,15 +299,6 @@ void __init check_ioapic(void) 
 #endif
 					/* RED-PEN skip them on mptables too? */
 					return;
-				case PCI_VENDOR_ID_ATI:
-					/* All timer interrupts on atiixp
-				           are doubled. Disable one. */
-					if (disable_timer_pin_1 == 0) {
-						disable_timer_pin_1 = 1;
-						printk(KERN_INFO
-		"ATI board detected. Disabling timer pin 1.\n");
-					}
-					return;
 				} 
 
 				/* No multi-function device? */

2.6.14-rc1 on ATI hangs when executing _STA and _INI methods

[Peter Osterlund]

Linus Torvalds <torvalds@osdl.org> writes:

> In other words, a lot of stuff all over the place. Be nice now, and follow 
> the rules: put away the new toys, and instead work on making sure the 
> stuff that got merged is all solid. Ok?

My Compaq Presario R3057EA hangs during ACPI initialization. The last
message is "Executing all Device _STA and _INI methods". git bisect
told me that:

  66759a01adbfe8828dd063e32cf5ed3f46696181 is first bad commit
  diff-tree 66759a01adbfe8828dd063e32cf5ed3f46696181 (from 049cdefe19f95b67b06b70915cd8e4ae7173337a)
  Author: Chuck Ebbert <76306.1226@compuserve.com>
  Date:   Mon Sep 12 18:49:25 2005 +0200

    [PATCH] x86-64: i386/x86-64: Fix time going twice as fast problem on ATI Xpress chipsets

    Original patch from Bertro Simul

    This is probably still not quite correct, but seems to be
    the best solution so far.

    Signed-off-by: Linus Torvalds <torvalds@osdl.org>

Passing enable_timer_pin_1 as a kernel boot parameter doesn't help,
but this patch does:

diff --git a/arch/i386/kernel/io_apic.c b/arch/i386/kernel/io_apic.c
--- a/arch/i386/kernel/io_apic.c
+++ b/arch/i386/kernel/io_apic.c
@@ -2213,8 +2213,6 @@ static inline void check_timer(void)
 				setup_nmi();
 				enable_8259A_irq(0);
 			}
-			if (disable_timer_pin_1 > 0)
-				clear_IO_APIC_pin(0, pin1);
 			return;
 		}
 		clear_IO_APIC_pin(0, pin1);

But doing that is equivalent to reverting the whole patch, so it's
probably not the right solution. My computer has an Intel P4 CPU, ie
it's not x86_64.

lspci output:

00:00.0 Host bridge: ATI Technologies Inc Radeon 9100 IGP Host Bridge (rev 02)
00:01.0 PCI bridge: ATI Technologies Inc Radeon 9100 IGP AGP Bridge
00:13.0 USB Controller: ATI Technologies Inc OHCI USB Controller #1 (rev 01)
00:13.1 USB Controller: ATI Technologies Inc OHCI USB Controller #2 (rev 01)
00:14.0 SMBus: ATI Technologies Inc ATI SMBus (rev 16)
00:14.1 IDE interface: ATI Technologies Inc ATI Dual Channel Bus Master PCI IDE Controller
00:14.3 ISA bridge: ATI Technologies Inc: Unknown device 434c
00:14.4 PCI bridge: ATI Technologies Inc: Unknown device 4342
00:14.5 Multimedia audio controller: ATI Technologies Inc IXP150 AC'97 Audio Controller
00:14.6 Modem: ATI Technologies Inc IXP AC'97 Modem (rev 01)
01:05.0 VGA compatible controller: ATI Technologies Inc M9+ 5C61 [Radeon Mobility 9200 (AGP)] (rev 01)
02:00.0 FireWire (IEEE 1394): Texas Instruments TSB43AB21 IEEE-1394a-2000 Controller (PHY/Link)
02:02.0 Network controller: Broadcom Corporation BCM4306 802.11b/g Wireless LAN Controller (rev 03)
02:03.0 Ethernet controller: Realtek Semiconductor Co., Ltd. RTL-8139/8139C/8139C+ (rev 10)
02:04.0 CardBus bridge: Texas Instruments PCI1620 PC Card Controller (rev 01)
02:04.1 CardBus bridge: Texas Instruments PCI1620 PC Card Controller (rev 01)
02:04.2 System peripheral: Texas Instruments PCI1620 Firmware Loading Function (rev 01)
02:07.0 USB Controller: NEC Corporation USB (rev 43)
02:07.1 USB Controller: NEC Corporation USB (rev 43)
02:07.2 USB Controller: NEC Corporation USB 2.0 (rev 04)

-- 
Peter Osterlund - petero2@telia.com
http://web.telia.com/~u89404340