mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ingo Oeser <ioe-lkml@rameria.de>
To: linux-kernel@vger.kernel.org
Cc: Nick Piggin <nickpiggin@yahoo.com.au>,
	"David S. Miller" <davem@davemloft.net>,
	clameter@engr.sgi.com
Subject: Re: making kmalloc BUG() might not be a good idea
Date: Fri, 23 Sep 2005 09:09:47 +0200	[thread overview]
Message-ID: <200509230909.54046.ioe-lkml@rameria.de> (raw)
In-Reply-To: <4333A109.2000908@yahoo.com.au>

[-- Attachment #1: Type: text/plain, Size: 827 bytes --]

Hi,

On Friday 23 September 2005 08:30, Nick Piggin wrote:
> David S. Miller wrote:
> >I'm sort-of concerned about this change:
> >
> >    [PATCH] __kmalloc: Generate BUG if size requested is too large.
> >
> >it opens a can of worms, and stuff that used to generate
> >-ENOMEM kinds of failures will now BUG() the kernel.
> Making it WARN might be a good compromise.

Which has the potential to spam the logs with a user triggerable event
without even killing the responsible process.
Same problem, just worse.

I could live with a solution that enables it based on a config.

KERNEL_HACKING is no such config. That feature is almost always
enabled, because MAGIC_SYSRQ depends on it and a significant amount
of Linux-Admins like it for a "sync, remount ro and reboot" sequence.
So you need a new one.


Regards

Ingo Oeser



[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]

  parent reply	other threads:[~2005-09-23  7:10 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-09-23  6:14 David S. Miller
2005-09-23  6:30 ` Nick Piggin
2005-09-23  6:54   ` David S. Miller
2005-09-23  7:09   ` Ingo Oeser [this message]
2005-09-23  7:58     ` Nick Piggin
2005-09-23  8:09       ` David S. Miller
2005-09-23  9:03         ` Nick Piggin
2005-09-23  9:17           ` Coywolf Qi Hunt
2005-09-23 15:58             ` Make kzalloc a macro Christoph Lameter
2005-09-23 17:50               ` Christoph Lameter
2005-09-23 22:37                 ` Andrew Morton
2005-09-26 17:38                   ` Christoph Lameter
2005-09-24 10:52               ` Denis Vlasenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200509230909.54046.ioe-lkml@rameria.de \
    --to=ioe-lkml@rameria.de \
    --cc=clameter@engr.sgi.com \
    --cc=davem@davemloft.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nickpiggin@yahoo.com.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®