From: Andrew Morton <akpm@osdl.org>
To: Christoph Lameter <clameter@engr.sgi.com>
Cc: nickpiggin@yahoo.com.au, davem@davemloft.net,
linux-kernel@vger.kernel.org
Subject: Re: Make kzalloc a macro
Date: Fri, 23 Sep 2005 15:37:02 -0700 [thread overview]
Message-ID: <20050923153702.6194e53f.akpm@osdl.org> (raw)
In-Reply-To: <Pine.LNX.4.62.0509231048530.22423@schroedinger.engr.sgi.com>
Christoph Lameter <clameter@engr.sgi.com> wrote:
>
> Make kzalloc a macro and use __GFP_ZERO for zeroed slab allocations
>
I'd question the usefulness of this. It adds more code to a fastpath
(kmem_cache_alloc) so as to speed up a slowpath (kzalloc()) which is
already slow due to its memset.
It makes my kernel a bit fatter too - 150-odd bytes of text for some
reason.
next prev parent reply other threads:[~2005-09-23 22:37 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-23 6:14 making kmalloc BUG() might not be a good idea David S. Miller
2005-09-23 6:30 ` Nick Piggin
2005-09-23 6:54 ` David S. Miller
2005-09-23 7:09 ` Ingo Oeser
2005-09-23 7:58 ` Nick Piggin
2005-09-23 8:09 ` David S. Miller
2005-09-23 9:03 ` Nick Piggin
2005-09-23 9:17 ` Coywolf Qi Hunt
2005-09-23 15:58 ` Make kzalloc a macro Christoph Lameter
2005-09-23 17:50 ` Christoph Lameter
2005-09-23 22:37 ` Andrew Morton [this message]
2005-09-26 17:38 ` Christoph Lameter
2005-09-24 10:52 ` Denis Vlasenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050923153702.6194e53f.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=clameter@engr.sgi.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=nickpiggin@yahoo.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®