* Re: Debugging neighbour.c: timers
[not found] ` <20050927003845.GA8273@ms2.inr.ac.ru>
@ 2005-09-27 0:48 ` David S. Miller
0 siblings, 0 replies; only message in thread
From: David S. Miller @ 2005-09-27 0:48 UTC (permalink / raw)
To: kuznet; +Cc: greearb, ja, netdev, linux-kernel, akpm
From: "A.N.Kuznetsov" <kuznet@ms2.inr.ac.ru>
Date: Tue, 27 Sep 2005 04:38:45 +0400
> Actually, when this code was written, add_timer() behaved differently,
> double add_timer() was prohibited and it printked
> "bug: kernel timer added twice at...".
Yes, it calls __mod_timer() now. That's quite bad and
the debugging check should be re-added I think.
Is there some reason why we want add_timer() to behave like
__mod_timer(timer, timer->expires)? I can't see any...
So perhaps we should add the simple BUG_ON(timer->pending) check to
include/linux/timer.h:add_timer()
add_timer_on() does this check btw....
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2005-09-27 0:48 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20050907.141847.95180907.davem@davemloft.net>
[not found] ` <43387327.20006@candelatech.com>
[not found] ` <20050927003845.GA8273@ms2.inr.ac.ru>
2005-09-27 0:48 ` Debugging neighbour.c: timers David S. Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®