mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Martin Schwidefsky <schwidefsky@de.ibm.com>
To: akpm@osdl.org, cohuck@de.ibm.com, linux-kernel@vger.kernel.org
Subject: [patch] s390: ccw device reconnect oops.
Date: Thu, 6 Oct 2005 13:10:47 +0200	[thread overview]
Message-ID: <20051006111047.GA7710@skybase.boeblingen.de.ibm.com> (raw)

Hi Andrew,
this patch is a bug fix that should be included in 2.6.14.
The klist bus_find_device/driver_find_device rework has introduced
the bug. The machine will oops if an online ccw device that has
been detached gets reconnected.

blue skies,
  Martin.

---

[patch] s390: ccw device reconnect oops.

From: Cornelia Huck <cohuck@de.ibm.com>

Search for a disconnect ccw_device on the ccw bus rather than on the css bus
(was a typo in patch I did for the klist conversion). A cast to an embedding
ccw_device from an embedded device in a struct subchannel will lead us to
oopses.

Signed-off-by: Cornelia Huck <cohuck@de.ibm.com>
Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com>

diff -urpN linux-2.6/drivers/s390/cio/device.c linux-2.6-patched/drivers/s390/cio/device.c
--- linux-2.6/drivers/s390/cio/device.c	2005-08-29 01:41:01.000000000 +0200
+++ linux-2.6-patched/drivers/s390/cio/device.c	2005-10-06 11:00:26.000000000 +0200
@@ -544,7 +544,7 @@ get_disc_ccwdev_by_devno(unsigned int de
 		.sibling = sibling,
 	};
 
-	dev = bus_find_device(&css_bus_type, NULL, &data, match_devno);
+	dev = bus_find_device(&ccw_bus_type, NULL, &data, match_devno);
 
 	return dev ? to_ccwdev(dev) : NULL;
 }

                 reply	other threads:[~2005-10-06 11:10 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20051006111047.GA7710@skybase.boeblingen.de.ibm.com \
    --to=schwidefsky@de.ibm.com \
    --cc=akpm@osdl.org \
    --cc=cohuck@de.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®