mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [patch] s390: ccw device reconnect oops.
@ 2005-10-06 11:10 Martin Schwidefsky
  0 siblings, 0 replies; only message in thread
From: Martin Schwidefsky @ 2005-10-06 11:10 UTC (permalink / raw)
  To: akpm, cohuck, linux-kernel

Hi Andrew,
this patch is a bug fix that should be included in 2.6.14.
The klist bus_find_device/driver_find_device rework has introduced
the bug. The machine will oops if an online ccw device that has
been detached gets reconnected.

blue skies,
  Martin.

---

[patch] s390: ccw device reconnect oops.

From: Cornelia Huck <cohuck@de.ibm.com>

Search for a disconnect ccw_device on the ccw bus rather than on the css bus
(was a typo in patch I did for the klist conversion). A cast to an embedding
ccw_device from an embedded device in a struct subchannel will lead us to
oopses.

Signed-off-by: Cornelia Huck <cohuck@de.ibm.com>
Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com>

diff -urpN linux-2.6/drivers/s390/cio/device.c linux-2.6-patched/drivers/s390/cio/device.c
--- linux-2.6/drivers/s390/cio/device.c	2005-08-29 01:41:01.000000000 +0200
+++ linux-2.6-patched/drivers/s390/cio/device.c	2005-10-06 11:00:26.000000000 +0200
@@ -544,7 +544,7 @@ get_disc_ccwdev_by_devno(unsigned int de
 		.sibling = sibling,
 	};
 
-	dev = bus_find_device(&css_bus_type, NULL, &data, match_devno);
+	dev = bus_find_device(&ccw_bus_type, NULL, &data, match_devno);
 
 	return dev ? to_ccwdev(dev) : NULL;
 }

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2005-10-06 11:10 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2005-10-06 11:10 [patch] s390: ccw device reconnect oops Martin Schwidefsky

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®