From: Rudolph Pereira <rudolph@faex.net>
To: Wes Newell <w.newell@verizon.net>
Cc: Aurelien Jarno <aurelien@aurel32.net>,
Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>,
Lionel.Bouton@inet6.fr, linux-kernel@vger.kernel.org,
linux-ide@vger.kernel.org
Subject: Re: [PATCH 2.6.14-rc3] sis5513.c: enable ATA133 for the SiS965 southbridge
Date: Tue, 11 Oct 2005 20:05:02 +1000 [thread overview]
Message-ID: <20051011100502.GB29008@delta.faex.net> (raw)
In-Reply-To: <4346A41E.3020505@verizon.net>
On Fri, Oct 07, 2005 at 11:36:46AM -0500, Wes Newell wrote:
> It appears to me that this patch will try and apply itself to the real
> SIS_180 which has the same true_id of 0x180. Can someone tell me what
> will happen then?
Indeed, I've tried Aurelien's patch and it works fine for me (on an asus
k8s-mx motherboard). Going back over the reasons for the patch that is
in -mm that I submitted, which was a rework of
a patch that Arnaud Patard/Uwe Koziolek sent to linux-ide, it seems that the
thinking was that complex probing and/or configuration was required for
this chipset. I don't have any specs to work from, and am not the expert
in any case, but it would seem that this is not necessary, and
just doing a standard detect of the southbridge id is fine.
Unless anyone has stronger evidence/experience, it would seem that the
simplest/cleanest solution is an update to SiSHostChipInfo[], as in Aurelien's
patch.
next prev parent reply other threads:[~2005-10-11 10:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-10-05 20:59 Aurelien Jarno
2005-10-06 9:40 ` Bartlomiej Zolnierkiewicz
2005-10-07 9:41 ` Aurelien Jarno
2005-10-07 16:36 ` Wes Newell
2005-10-11 10:05 ` Rudolph Pereira [this message]
2005-10-21 20:35 ` wsong
2005-10-21 22:25 ` Francois Romieu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051011100502.GB29008@delta.faex.net \
--to=rudolph@faex.net \
--cc=Lionel.Bouton@inet6.fr \
--cc=aurelien@aurel32.net \
--cc=bzolnier@gmail.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=w.newell@verizon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®