From: Francois Romieu <romieu@fr.zoreil.com>
To: wsong <wsong.cn@gmail.com>
Cc: linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org
Subject: Re: [PATCH 2.6.14-rc3] sis5513.c: enable ATA133 for the SiS965 southbridge
Date: Sat, 22 Oct 2005 00:25:16 +0200 [thread overview]
Message-ID: <20051021222516.GA18899@electric-eye.fr.zoreil.com> (raw)
In-Reply-To: <6f9b6d3e0510211335x202a437co1919df4f7e5aeb2f@mail.gmail.com>
wsong <wsong.cn@gmail.com> :
> This patch has conflict with sata_sis driver. They both register this
> id 0x0180. But pci ide driver is loaded first. So if you have sata
> drive connected as root, dang, you'll get kernel panic. I had this
> problem with 2.6.14_rc4-mm1. Simply delete the third line from
> structure sis5513_pci_tbl resolved it.
>
> I know it's just a work around.
The lspci I have received for a k8s-mx exhibit a 5513 whose PCI ID is
already correctly set. If the ID masking and register remapping is not
really relevant on a 180, the code below could be enough. If it is wrong,
it may be better to check the availability of a good backup system before
using it.
Some features documentation suggest that the 760 and the 755 should
mostly go along with the same southbridge.
Signed-off-by: Francois Romieu <romieu@fr.zoreil.com>
diff --git a/drivers/ide/pci/sis5513.c b/drivers/ide/pci/sis5513.c
--- a/drivers/ide/pci/sis5513.c
+++ b/drivers/ide/pci/sis5513.c
@@ -20,6 +20,7 @@
* ATA16/33 support from specs
* ATA133 support for SiS961/962 by L.C. Chang <lcchang@sis.com.tw>
* ATA133 961/962/963 fixes by Vojtech Pavlik <vojtech@suse.cz>
+ * ATA133 965 hack by Ueimor <romieu@fr.zoreil.com>
*
* Documentation:
* SiS chipset documentation available under NDA to companies only
@@ -87,6 +88,9 @@ static const struct {
u8 chipset_family;
u8 flags;
} SiSHostChipInfo[] = {
+ { "SiS760", PCI_DEVICE_ID_SI_760, ATA_133 },
+ { "SiS755", PCI_DEVICE_ID_SI_755, ATA_133 },
+
{ "SiS745", PCI_DEVICE_ID_SI_745, ATA_100 },
{ "SiS735", PCI_DEVICE_ID_SI_735, ATA_100 },
{ "SiS733", PCI_DEVICE_ID_SI_733, ATA_100 },
prev parent reply other threads:[~2005-10-21 22:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-10-05 20:59 Aurelien Jarno
2005-10-06 9:40 ` Bartlomiej Zolnierkiewicz
2005-10-07 9:41 ` Aurelien Jarno
2005-10-07 16:36 ` Wes Newell
2005-10-11 10:05 ` Rudolph Pereira
2005-10-21 20:35 ` wsong
2005-10-21 22:25 ` Francois Romieu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051021222516.GA18899@electric-eye.fr.zoreil.com \
--to=romieu@fr.zoreil.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wsong.cn@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®