[PATCH] Kconfig fix, (ES7000 dependencies)

[PATCH] Kconfig fix, (ES7000 dependencies)

[Peter Hagervall]

Targets X86_GENERICARCH and X86_ES7000 fail to build without
CONFIG_ACPI.

Signed-off-by: Peter Hagervall <hager@cs.umu.se>
---

diff --git a/arch/i386/Kconfig b/arch/i386/Kconfig
--- a/arch/i386/Kconfig
+++ b/arch/i386/Kconfig
@@ -115,14 +115,14 @@ config X86_VISWS
 
 config X86_GENERICARCH
        bool "Generic architecture (Summit, bigsmp, ES7000, default)"
-       depends on SMP
+       depends on SMP && ACPI
        help
           This option compiles in the Summit, bigsmp, ES7000, default subarchitectures.
 	  It is intended for a generic binary kernel.
 
 config X86_ES7000
 	bool "Support for Unisys ES7000 IA32 series"
-	depends on SMP
+	depends on SMP && ACPI
 	help
 	  Support for Unisys ES7000 systems.  Say 'Y' here if this kernel is
 	  supposed to run on an IA32-based Unisys ES7000 system.

RE: [PATCH] Kconfig fix, (ES7000 dependencies)

[Protasevich, Natalie]

> > Targets X86_GENERICARCH and X86_ES7000 fail to build without 
> > CONFIG_ACPI.
> > 
> > Signed-off-by: Peter Hagervall <hager@cs.umu.se>
> > ---
> > 
> > diff --git a/arch/i386/Kconfig b/arch/i386/Kconfig
> > --- a/arch/i386/Kconfig
> > +++ b/arch/i386/Kconfig
> > @@ -115,14 +115,14 @@ config X86_VISWS
> >  
> >  config X86_GENERICARCH
> >         bool "Generic architecture (Summit, bigsmp, ES7000, 
> default)"
> > -       depends on SMP
> > +       depends on SMP && ACPI
> >         help
> >            This option compiles in the Summit, bigsmp, 
> ES7000, default 
> > subarchitectures.
> >  	  It is intended for a generic binary kernel.
> >  
> >  config X86_ES7000
> >  	bool "Support for Unisys ES7000 IA32 series"
> > -	depends on SMP
> > +	depends on SMP && ACPI
> >  	help
> >  	  Support for Unisys ES7000 systems.  Say 'Y' here if 
> this kernel is
> >  	  supposed to run on an IA32-based Unisys ES7000 system.
> 
> 
> No, ES7000 doesn't have to depend on ACPI, it uses MPS for 
> testing/failsafe purposes a lot. I had a patch for the build 
> bix submitted 
> http://bugzilla.kernel.org/show_bug.cgi?id=5124, I think Len 
> was going to sort it out.

Peter, I'd have to take it back - no objections to ACPI dependency for
ES7000 (since the acpi=off switch will serve our needs just fine). The
patch I had is perhaps too elaborate :) and it's easier just do it as
you suggested. As long as no worries from other genapic entities (like
Summit? or someone out there with large configuration and no ACPI), the
patch is fine with me.
Thanks,
--Natalie 

RE: [PATCH] Kconfig fix, (ES7000 dependencies)

[Protasevich, Natalie]

> Targets X86_GENERICARCH and X86_ES7000 fail to build without 
> CONFIG_ACPI.
> 
> Signed-off-by: Peter Hagervall <hager@cs.umu.se>
> ---
> 
> diff --git a/arch/i386/Kconfig b/arch/i386/Kconfig
> --- a/arch/i386/Kconfig
> +++ b/arch/i386/Kconfig
> @@ -115,14 +115,14 @@ config X86_VISWS
>  
>  config X86_GENERICARCH
>         bool "Generic architecture (Summit, bigsmp, ES7000, default)"
> -       depends on SMP
> +       depends on SMP && ACPI
>         help
>            This option compiles in the Summit, bigsmp, 
> ES7000, default subarchitectures.
>  	  It is intended for a generic binary kernel.
>  
>  config X86_ES7000
>  	bool "Support for Unisys ES7000 IA32 series"
> -	depends on SMP
> +	depends on SMP && ACPI
>  	help
>  	  Support for Unisys ES7000 systems.  Say 'Y' here if 
> this kernel is
>  	  supposed to run on an IA32-based Unisys ES7000 system.


No, ES7000 doesn't have to depend on ACPI, it uses MPS for
testing/failsafe purposes a lot. I had a patch for the build bix
submitted http://bugzilla.kernel.org/show_bug.cgi?id=5124, I think Len
was going to sort it out.
Thanks,
--Natalie

> To unsubscribe from this list: send the line "unsubscribe 
> linux-kernel" in the body of a message to 
> majordomo@vger.kernel.org More majordomo info at  
> http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
>