* ppc64: Fix typo bug in iSeries hash code
@ 2005-10-21 3:41 David Gibson
0 siblings, 0 replies; only message in thread
From: David Gibson @ 2005-10-21 3:41 UTC (permalink / raw)
To: Linus Torvalds, Andrew Morton
Cc: Paul Mackerras, linuxppc64-dev, linux-kernel
Linus, please apply for 2.6.14 - this one-liner fixes a serious bug.
This patch fixes a stupid typo bug in the iSeries hash table code.
When we place a hash PTE in the secondary bucket, instead of setting
the SECONDARY flag bit, as we should, we (redundantly) set the VALID
flag. This was introduced with the patch abolishing bitfields from
the hash table code. Mea culpa, oops. It hasn't been noticed until
now because in practice we don't hit the secondary bucket terribly
often.
Signed-off-by: David Gibson <dwg@au1.ibm.com>
Index: working-2.6/arch/ppc64/kernel/iSeries_htab.c
===================================================================
--- working-2.6.orig/arch/ppc64/kernel/iSeries_htab.c 2005-10-21 13:29:50.000000000 +1000
+++ working-2.6/arch/ppc64/kernel/iSeries_htab.c 2005-10-21 13:30:55.000000000 +1000
@@ -66,7 +66,7 @@
}
if (slot < 0) { /* MSB set means secondary group */
- vflags |= HPTE_V_VALID;
+ vflags |= HPTE_V_SECONDARY;
secondary = 1;
slot &= 0x7fffffffffffffff;
}
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/people/dgibson
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2005-10-21 3:41 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2005-10-21 3:41 ppc64: Fix typo bug in iSeries hash code David Gibson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®