Re: [PATCH] ohci1394 PCI fixup for Toshiba laptops

[Greg KH <greg@kroah.com>]

On Tue, Oct 25, 2005 at 10:19:16AM -0700, Jesse Barnes wrote:
> On Tuesday, October 25, 2005 12:02 am, Stefan Richter wrote:
> > Jesse Barnes wrote:
> > > +static void __devinit pci_post_fixup_toshiba_ohci1394(struct
> > > pci_dev *dev) +{
> > > +	if (dmi_check_system(toshiba_ohci1394_dmi_table))
> > > +		return; /* only applies to certain Toshibas (so far) */
> > > +
> > > +	/* Restore config space on Toshiba laptops */
> > > +	mdelay(10);
> > > +	pci_write_config_word(dev, PCI_CACHE_LINE_SIZE,
> > > toshiba_line_size);
> >
> > Shouldn't this read
> >
> >          if (!dmi_check_system(toshiba_ohci1394_dmi_table))
> >                  return;
> >              ^ ?
> >
> > dmi_check_system returns the number of matches.
> 
> Doh!  Yes, it should be (I tested an earlier version, then decided to 
> reverse the logic and return, oops).
> 
> Here's an updated version.
> 
> Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>

Care to resend with the full changelog information too, so I can apply
it?

thanks,

greg k-h