From: Stefan Richter <stefanr@s5r6.in-berlin.de>
To: Jesse Barnes <jbarnes@virtuousgeek.org>
Cc: gregkh@suse.de, linux-kernel@vger.kernel.org,
linux-pci@atrey.karlin.mff.cuni.cz, rob@janerob.com,
akpm@osdl.org
Subject: Re: [PATCH] ohci1394 PCI fixup for Toshiba laptops
Date: Tue, 25 Oct 2005 09:02:07 +0200 [thread overview]
Message-ID: <435DD86F.3090702@s5r6.in-berlin.de> (raw)
In-Reply-To: <200510241857.33257.jbarnes@virtuousgeek.org>
Jesse Barnes wrote:
> +static void __devinit pci_post_fixup_toshiba_ohci1394(struct pci_dev *dev)
> +{
> + if (dmi_check_system(toshiba_ohci1394_dmi_table))
> + return; /* only applies to certain Toshibas (so far) */
> +
> + /* Restore config space on Toshiba laptops */
> + mdelay(10);
> + pci_write_config_word(dev, PCI_CACHE_LINE_SIZE, toshiba_line_size);
Shouldn't this read
if (!dmi_check_system(toshiba_ohci1394_dmi_table))
return;
^ ?
dmi_check_system returns the number of matches.
--
Stefan Richter
-=====-=-=-= =-=- ==--=
http://arcgraph.de/sr/
next prev parent reply other threads:[~2005-10-25 7:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-10-25 1:57 Jesse Barnes
2005-10-25 7:02 ` Stefan Richter [this message]
2005-10-25 17:19 ` Jesse Barnes
2005-10-25 17:22 ` Greg KH
2005-10-25 17:28 ` Jesse Barnes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=435DD86F.3090702@s5r6.in-berlin.de \
--to=stefanr@s5r6.in-berlin.de \
--cc=akpm@osdl.org \
--cc=gregkh@suse.de \
--cc=jbarnes@virtuousgeek.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@atrey.karlin.mff.cuni.cz \
--cc=rob@janerob.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®