mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] ibmveth fix panic in initial replenish cycle
@ 2005-11-01 19:15 Santiago Leon
  2005-11-04 22:23 ` John W. Linville
  0 siblings, 1 reply; 2+ messages in thread
From: Santiago Leon @ 2005-11-01 19:15 UTC (permalink / raw)
  To: Linus Torvalds; +Cc: Santiago Leon, netdev, lkml, Jeff Garzik

This patch fixes a panic in the current tree caused by a race condition between the initial replenish cycle and the rx processing of the first packets trying to replenish the buffers.

Signed-off-by: Santiago Leon <santil@us.ibm.com>

diff --git a/drivers/net/ibmveth.c b/drivers/net/ibmveth.c
--- a/drivers/net/ibmveth.c
+++ b/drivers/net/ibmveth.c
@@ -535,7 +535,7 @@ static int ibmveth_open(struct net_devic
 	}
 
 	ibmveth_debug_printk("initial replenish cycle\n");
-	ibmveth_replenish_task(adapter);
+	ibmveth_interrupt(netdev->irq, netdev, NULL);
 
 	netif_start_queue(netdev);
 

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] ibmveth fix panic in initial replenish cycle
  2005-11-01 19:15 [PATCH] ibmveth fix panic in initial replenish cycle Santiago Leon
@ 2005-11-04 22:23 ` John W. Linville
  0 siblings, 0 replies; 2+ messages in thread
From: John W. Linville @ 2005-11-04 22:23 UTC (permalink / raw)
  To: Santiago Leon; +Cc: Linus Torvalds, netdev, lkml, Jeff Garzik

On Tue, Nov 01, 2005 at 02:15:09PM -0500, Santiago Leon wrote:
> This patch fixes a panic in the current tree caused by a race condition between the initial replenish cycle and the rx processing of the first packets trying to replenish the buffers.

Please restrain your line widths to less than 80 characters.  72 is
a nice number IMHO.

Thanks,

John
-- 
John W. Linville
linville@tuxdriver.com

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2005-11-04 22:25 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2005-11-01 19:15 [PATCH] ibmveth fix panic in initial replenish cycle Santiago Leon
2005-11-04 22:23 ` John W. Linville

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®