mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Zachary Amsden <zach@vmware.com>
Cc: Andrew Morton <akpm@osdl.org>, Chris Wright <chrisw@osdl.org>,
	Linus Torvalds <torvalds@osdl.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Virtualization Mailing List <virtualization@lists.osdl.org>,
	"H. Peter Anvin" <hpa@zytor.com>,
	Zwane Mwaikambo <zwane@arm.linux.org.uk>,
	Martin Bligh <mbligh@mbligh.org>,
	Pratap Subrahmanyam <pratap@vmware.com>,
	Christopher Li <chrisl@vmware.com>,
	"Eric W. Biederman" <ebiederm@xmission.com>
Subject: Re: [PATCH 4/21] i386 Broken bios common
Date: Tue, 8 Nov 2005 08:19:35 +0100	[thread overview]
Message-ID: <20051108071935.GB28201@elte.hu> (raw)
In-Reply-To: <200511080422.jA84MQxK009859@zach-dev.vmware.com>


* Zachary Amsden <zach@vmware.com> wrote:

>  	gdt = get_cpu_gdt_table(cpu);
>  	save_desc_40 = gdt[0x40 / 8];
> -	gdt[0x40 / 8] = bad_bios_desc;
> +	gdt[0x40 / 8] = gdt[GDT_ENTRY_BAD_BIOS_CACHE];
>  

i like the cleanup, but wouldnt it be simpler to dedicate GDT entry #8 
to the 0x40 descriptor, and hence be compatible with such broken BIOSes 
by default? Right now entry #8 is taken up by TLS segment #2, but we 
could change GDT_ENTRY_TLS_MIN from 6 to 9 and push the TLS segments to 
entries 9,10,11. [ Could there be any buggy SMM code that relies on 
having something at 0x40? ]

	Ingo

  reply	other threads:[~2005-11-08  7:19 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-11-08  4:22 Zachary Amsden
2005-11-08  7:19 ` Ingo Molnar [this message]
2005-11-08 12:48   ` Zachary Amsden
2005-11-08 12:57     ` Ingo Molnar
2005-11-08 15:06 ` Linus Torvalds
2005-11-08 15:16   ` H. Peter Anvin
2005-11-08 21:07   ` Zachary Amsden
2005-11-08 21:52   ` Zachary Amsden

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20051108071935.GB28201@elte.hu \
    --to=mingo@elte.hu \
    --cc=akpm@osdl.org \
    --cc=chrisl@vmware.com \
    --cc=chrisw@osdl.org \
    --cc=ebiederm@xmission.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mbligh@mbligh.org \
    --cc=pratap@vmware.com \
    --cc=torvalds@osdl.org \
    --cc=virtualization@lists.osdl.org \
    --cc=zach@vmware.com \
    --cc=zwane@arm.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®